From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qJT6Cdk4QmarnwAAqHPOHw:P1 (envelope-from ) for ; Mon, 13 May 2024 17:59:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qJT6Cdk4QmarnwAAqHPOHw (envelope-from ) for ; Mon, 13 May 2024 17:59:21 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="BYJ/vPXB"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715615961; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4TR26eFIcTtDejpeU0jZ0pWiV9vWqCq7OwWRny/gdBI=; b=YCwTmxzavXAMV0TcvEQ4Z4/TKIk5AKpobE+TxTxQxiCdf7LfIkq3p1sq/ZD2UJfB9eyUWU ACW+hpiSIc3OIfswuWYGn5NT4r0Cm77W28S4olwIj2M8wyQKuXfXZ43zK4WxjHbJx+Ie27 /HRa6lDPnxg4PbMu6Kpn8uoO1gBsJ1diTpDGaWIDfaolRVgwmYQa+Wr3GE1Es49eCZN4r9 aw3UqlD65csUyC0w/p3CZr7Doc1X1kZr474JQVixf8LMVaeaHvjOnEK2jdeINoTrse+Ob0 q0a0FKOwKErGDP3Cz6IsHgcb0sFJb/EXAwC1qVQLejDVzcKqfRj0WHZDPsyHoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="BYJ/vPXB"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715615961; a=rsa-sha256; cv=none; b=eGW2EOOQQIC34yAPYbA5JUhprDaE2PYO2Ne+afoSJ5HD4Sz53Ia3OkGmALXr8CkZQpTa/3 5nxshTemIZIZg3zCk22rTBZVA9ZN3uLiR5c0ljTU3ATgMsKfOSTEaV3XLRiZIksVIC8BFQ hUvXEFkdkHDY2Q2Sv1CWwdD3xpvT3Reet+1gWbtLmKFhZITZtMSqVrxqyljHYm+q7KpW3b PfAyrUuvcsyA26vKwgKhA0v/7luF/23buY0MZKH+IoBW2qLqoft65k/+4GCSUi/s2RnwPd kH1OUwQeYyqM15Mj0ntAiydfd/EfKsLfr+CIjKhHR5BVPATP+hGMnq03mS5AhA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED7A63F2F4 for ; Mon, 13 May 2024 17:59:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6Y4u-0008EN-Sx; Mon, 13 May 2024 11:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Y4r-0008Ci-VC for guix-patches@gnu.org; Mon, 13 May 2024 11:59:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6Y4r-0002co-Mp for guix-patches@gnu.org; Mon, 13 May 2024 11:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6Y4r-0000MP-VJ for guix-patches@gnu.org; Mon, 13 May 2024 11:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70494] [PATCH 06/23] store: Export protocol related constants. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 May 2024 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , 70494@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 70494-submit@debbugs.gnu.org id=B70494.17156159061350 (code B ref 70494); Mon, 13 May 2024 15:59:01 +0000 Received: (at 70494) by debbugs.gnu.org; 13 May 2024 15:58:26 +0000 Received: from localhost ([127.0.0.1]:33464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Y4H-0000Lh-TS for submit@debbugs.gnu.org; Mon, 13 May 2024 11:58:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6Y4E-0000LX-1Z for 70494@debbugs.gnu.org; Mon, 13 May 2024 11:58:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Y46-0002Wh-Eu; Mon, 13 May 2024 11:58:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=4TR26eFIcTtDejpeU0jZ0pWiV9vWqCq7OwWRny/gdBI=; b=BYJ/vPXBS79HhTiCbIia mqQB1o9LKo1prWQYzLGY2GhsOfTy4YhK5RYxf/zf+VeVFAIf8J3QFNaNNm4ALaiYK3/EBfXEZqTsT LUv0FNfV9bJaAh50epo1I3y3GqP0jtvixc5IUU6B9TjvToE8nOn8x0kGgOsWSLrmnLxQ3BXXZ7Y9B qlN74ag9GbCAd5VU+B0mS5RT5Q0pn6YWt/r6gm591crQUlEMKzI0/PgFsPvr70MJMNugQk4mfw5oI b0Hh4XZ7zGXZvaCnvJmty+AOxkx2TeTk+uRjLlSBwMGcP75nb+Viyc9Flmt3rIWojtvJCj/LuxIY+ cWSi9TFE6OX4LQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Christopher Baines's message of "Sun, 21 Apr 2024 10:42:24 +0100") References: <87bk632h36.fsf@cbaines.net> Date: Mon, 13 May 2024 17:58:04 +0200 Message-ID: <87bk59901f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.77 X-Spam-Score: -5.77 X-Migadu-Queue-Id: ED7A63F2F4 X-Migadu-Scanner: mx13.migadu.com X-TUID: zn/t3s21YzPJ Christopher Baines skribis: > * guix/store.scm (%protocol-version, %worker-magic-1, %worker-magic-2): E= xport > variables. > (protocol-major, protocol-minor, protocol-version): Export procedures. > (%stderr-next, %stderr-read, %stderr-write, %stderr-last, %stderr-error): > Move from process-stderr and export variables. > > Change-Id: Id0b1b5e6feeac5260875558f33aa5d923d5e0903 > --- > guix/store.scm | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/guix/store.scm b/guix/store.scm > index c3b58090e5..578e46507e 100644 > --- a/guix/store.scm > +++ b/guix/store.scm > @@ -206,18 +206,25 @@ (define-module (guix store) > derivation-log-file > log-file)) >=20=20 > -(define %protocol-version #x164) > +(define-public %protocol-version #x164) >=20=20 > -(define %worker-magic-1 #x6e697863) ; "nixc" > -(define %worker-magic-2 #x6478696f) ; "dxio" > +(define-public %worker-magic-1 #x6e697863) ; "nixc" > +(define-public %worker-magic-2 #x6478696f) ; "dxio" Two things: 1. This is a case for a new (guix store protocol) module. Preferably I would keep those constants local to that module and instead expose higher-level facilities, but we can start by just exporting these constants. 2. From a cosmetic viewpoint, please use #:export rather than =E2=80=98define-public=E2=80=99, for clarity (package modules are the = exception). Ludo=E2=80=99.