From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: maxim.cournoyer@gmail.com, 72674@debbugs.gnu.org
Subject: [bug#72674] [PATCH] gnu: guix: Remove unnecessary dependencies.
Date: Sat, 17 Aug 2024 09:13:57 +0200 [thread overview]
Message-ID: <87bk1rmxje.fsf@gnu.org> (raw)
In-Reply-To: <d68cc8dbe1e46fea5188fc1ad5e122e1e2c07cb7.1723830740.git.ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 16 Aug 2024 19:54:36 +0200")
Ludovic Courtès writes:
Hi!
> Removing this extra dependencies make it simpler to build the ‘guix’
> package in particular on less-capable systems like i586-gnu.
> As Janneke noted in <https://issues.guix.gnu.org/72643#7-lineno16>,
> the new imagemagick dependency made it harder to get ‘guix’ built on
> i586-gnu. It’s also unnecessary.
Nice catch!
> diff --git a/manifest.scm b/manifest.scm
> index 7e4d82c3a5..27e1d62566 100644
> --- a/manifest.scm
> +++ b/manifest.scm
> @@ -24,11 +24,25 @@
> ;;
> ;; guix shell --pure -m manifest.scm hello ...
>
> +(use-modules (guix packages))
> +
> (concatenate-manifests
> - (list (package->development-manifest (specification->package "guix"))
> + (list (package->development-manifest
> + (let ((guix (specification->package "guix")))
> + (package/inherit guix
> + ;; Replace with non-minimal Graphviz for PDF support.
> + (native-inputs (modify-inputs (package-native-inputs guix)
> + (replace "graphviz"
> + (specification->package "graphviz")))))))
> +
> ;; Extra packages used by unit tests.
> (specifications->manifest (list "gnupg"))
>
> + ;; Packages needed for 'make dist' and 'make distcheck'.
> + (specifications->manifest
> + (list "imagemagick"
> + "perl"))
> +
Would it be overkill to avoid this for target-hurd?, someting like
(use-modules (guix utils)
;; ...
(specifications->manifest
(if (target-hurd?)
'()
(list "imagemagick"
"perl"))
Maybe it's premature; as I'm not even sure if fails to builds natively;
some of its dependencies don't cross-build, but it may just build on the
Hurd? I haven't built a guix checkout in a childhurd for some time...
Greetings,
Janneke
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
next prev parent reply other threads:[~2024-08-17 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 17:54 [bug#72674] [PATCH] gnu: guix: Remove unnecessary dependencies Ludovic Courtès
2024-08-17 7:13 ` Janneke Nieuwenhuizen [this message]
2024-08-19 8:45 ` Ludovic Courtès
2024-08-19 9:04 ` Janneke Nieuwenhuizen
2024-08-31 17:09 ` bug#72674: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk1rmxje.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=72674@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.