From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cJgFBnPYFmf8qAAAqHPOHw:P1 (envelope-from ) for ; Mon, 21 Oct 2024 22:40:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id cJgFBnPYFmf8qAAAqHPOHw (envelope-from ) for ; Tue, 22 Oct 2024 00:40:51 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Tc0CxjaA; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ExoSWiCE; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729550451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=McOendSCuo/eZf5zcQTTv/LqHicJfbD3xNQv2jQ3i4k=; b=hT4XjMZVkjJrMtP794blUHe1K6lyvHsxVd66O5+huVRXIDGhdc8xrFOCquGe8HFuTEVRMp LM9yycPlgYc1S/HPaaRTBjandVxcS4ANGl4wJmeIzrJtKvi5r1kfnpCYH3qmXa5pnIy0t+ 6SJ4+bzHEVSKZ3o4RkTMeDIl8mYWl7XruNwziRAYwSRgqxktLc1w34luCIyye3B6SeQYPv D9LtFmbcisaehyW4aYOhR/UiN/Jya69+0gQ/kjwRJWvZPSS/2mVgeEGCBbp011XqIJ4yaI oLMsMjdIYg7FTrAffLmvdpzmN9kCbGuW05EO9YuwnRbSFN97yDJK93NJea6xqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729550451; a=rsa-sha256; cv=none; b=ObwZax9/ur6DGweYykfCzNEutnx+u3Q3VEnh85XdHmjVyR+DXDG2YmQW42xKZnVpyzIjgf YOmdkGDKB1ihYFx0IzQw5M4dvoKMnq4DOpH5RCFW5gKMIAeXFVHoP7tKqf9X3uXnuhosxy YumiW8LGS+zrf5piq1jULTyq+ZG46pwB4/LpIFr15/HRDM1FhaXgtwP/6HJh47z04jfDLa CwoKzt+kKtt5RLMpmVndNy+KexGWISYE/XD+/ZfkUpVEhlIfahU6wRsfamCyCLpSUkVY1T SFAzkB3iV9sk7OgckTXeqEXI6oW1pGOHfl6qlmDv+D3exZaAsDBFyJuWPYs2OQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Tc0CxjaA; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ExoSWiCE; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E44BB517AE for ; Tue, 22 Oct 2024 00:40:49 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t30w8-0004w7-9f; Mon, 21 Oct 2024 18:31:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t30w4-0004vb-05 for guix-patches@gnu.org; Mon, 21 Oct 2024 18:31:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t30w3-0003of-Ny for guix-patches@gnu.org; Mon, 21 Oct 2024 18:31:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=McOendSCuo/eZf5zcQTTv/LqHicJfbD3xNQv2jQ3i4k=; b=Tc0CxjaAxFR89XsNPEOo8fpn59ivDTUgAbd2Xp5kE3vQuCN2Z6wwz2Iw82EIVq66VuBlOdwpLiNESjSNtq2m5EeXp2QFccwObqmfZqNxrpug8uncKRVaDRmp5E3yEyxaotpW0QhuqxbaO/VNCmFODebT6//7Oonh9mKC8UhZgnyROnQdMnF9y8WSJn9ttsVajKrFflnpAS6Awr/IuSX3UTpMuEPm297WAZaWLQjaeROchXJ43fSUvQYwbyHyARaAa1TXu0WHXJ9X6gZ0oozsyx/7jIZ+XTY0ribMpcTUpsKXiprgPXYXsBi7Gn/nTz529CplL0Jn7dqETSJMuu4v8w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t30wU-00027Z-Lp for guix-patches@gnu.org; Mon, 21 Oct 2024 18:32:02 -0400 Subject: bug#73674: [PATCH] shell: Enable caching when using deterministic package transformations. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 21 Oct 2024 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73674 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73674-done@debbugs.gnu.org Cc: Tobias Geerinckx-Rice , Christopher Baines , Josselin Poiret , Simon Tournier , Mathieu Othacehe Mail-Followup-To: 73674@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 73674-done@debbugs.gnu.org id=D73674.17295498798088 (code D ref 73674); Mon, 21 Oct 2024 22:32:02 +0000 Received: (at 73674-done) by debbugs.gnu.org; 21 Oct 2024 22:31:19 +0000 Received: from localhost ([127.0.0.1]:53867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t30vm-00026O-RD for submit@debbugs.gnu.org; Mon, 21 Oct 2024 18:31:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t30vl-00026B-8Q for 73674-done@debbugs.gnu.org; Mon, 21 Oct 2024 18:31:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t30vE-0003mG-Tq; Mon, 21 Oct 2024 18:30:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=McOendSCuo/eZf5zcQTTv/LqHicJfbD3xNQv2jQ3i4k=; b=ExoSWiCE8JOEmdZ+GEu6 MLx7KQc423o4v9BBOJQ7ueRBoIiUENQqvA8I8J3dM/lgAMWMieW/B7KBFKxTWzthMJ5eKih3r6x2f RiF+TCWFDYjD3odp8Js8GwJtjoxkj0NY/MpUCUfq8f2Z4Aoyw+s3HeCxntHG99I3mSJVQSF/PlPdq xU1YInK4HERPi4n47d0FiulG3nOeCYq2QfCcZ0hF7dE6yn6TepWpF2rZnkcWVgHhRrKHnZ0EQ9cdt RcXG3z3rD3kfjo4Z24odmdfckyori8VrJXfTdfBhjqPJsYc5Loapb/b1N6s+50Kw3Ggu3FfWHWxA+ iAO0RTCEwoSSTA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 7 Oct 2024 10:35:55 +0200") References: Date: Tue, 22 Oct 2024 00:30:41 +0200 Message-ID: <87bjzdccmm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.95 X-Spam-Score: -1.95 X-Migadu-Queue-Id: E44BB517AE X-Migadu-Scanner: mx13.migadu.com X-TUID: 90KXCJWUDwcd Ludovic Court=C3=A8s skribis: > From: Ludovic Court=C3=A8s > > Until now, using any package transformation would disable the automatic > GC root creation and caching in =E2=80=98guix shell=E2=80=99. This chang= e introduces a > finer-grain distinction: a command like: > > guix shell --tune inkscape > > is now subject to caching, whereas: > > guix shell --with-latest=3Dinkscape inkscape > > remains non-cacheable. > > * guix/transformations.scm (%transformations-with-external-dependencies): > New variable. > (cacheable-transformation-option-key?): New procedure. > * guix/scripts/shell.scm (profile-cached-gc-root): In the > =E2=80=98transformation-option-key?=E2=80=99 clause, call =E2=80=98loop= =E2=80=99 when > =E2=80=98cacheable-transformation-option-key?=E2=80=99 returns true. > > Change-Id: I847b661dfea20ecf851db2023a5c7ea8c5b5ca7c I went ahead and pushed it as 6d8107c967a554e23b0c58c8933894d4468ad596. Ludo=E2=80=99.