From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wOIyLwLXJGeThAEAqHPOHw:P1 (envelope-from ) for ; Fri, 01 Nov 2024 13:26:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wOIyLwLXJGeThAEAqHPOHw (envelope-from ) for ; Fri, 01 Nov 2024 14:26:26 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=IqJ7iMsi; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YjYUogWR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730467586; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=u8GT3HNyjt3EPlQvlbL6gJRs1OKb+ovMfacSNJtIx3Y=; b=qFaGhEUqA4Gk0qAA8MYPu1Pdx8XhW0ZGWac+lesz6RQyCI1bfqmOfvAYZw3x1U+z97iQ4L VfH1g14mikjNr4vwyODf8ze1d+7PbD+yXZ0wAJ688y8ZiGZEjxLnUtxVNDDP27+FDHXcGP l+wIIGihWbjnS1XeDByV8l1wZ1P5ccf5Y3C5m3K8WX50a9jCSY+V7Xyz8sBbK3kNgcq5Ht 6ACd39a3sQDsc7ca9M2R0uqAUz1aqTj6Mkce1bBzfDwcTEASufu7f6lC+3ch9LUyP5DPjZ ZXu/jvknWlr1k8Y73Qme1UOaHDLoNknxhe3Wosx++GEaCpQNuRa6RAvskHSnTA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730467586; a=rsa-sha256; cv=none; b=ThxN7Xs10gp+TXlyNoQStqMWpQcVvNL52ajxU7YUt8BbyQm6gE61/U/xZT+BlytT5dhLXe 5SxjWRvAV0uxWHpOp4nDE5GyBwQHouvx8rtgYUaVlmFfqoKVd2mKWypEGIeg51YGxvThmU ptDXPV9/F+ea/o5st3Zz0r2We8R4ua2mHcs9p1Kyz7PM11yo4iQSFOzjK5rC07BS6nEfJw 6BGRtQRr0D1X/7/HM854AiGRPXaosI34izz10n0tfQKKIg4aNKMh8fhRkDT5ZroQeKYePe jFEddDZuTD/uVZSXSW5hgpnPG94IzrO7ZpL2NsiseqBkR5OmO0V+/bXe/cTLDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=IqJ7iMsi; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=YjYUogWR; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CF9D7661 for ; Fri, 01 Nov 2024 14:26:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6rfC-0000yP-Pm; Fri, 01 Nov 2024 09:26:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6rf9-0000yF-44 for guix-patches@gnu.org; Fri, 01 Nov 2024 09:26:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6rf8-0006uS-4W for guix-patches@gnu.org; Fri, 01 Nov 2024 09:26:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=u8GT3HNyjt3EPlQvlbL6gJRs1OKb+ovMfacSNJtIx3Y=; b=IqJ7iMsieYFs7p5m9ekT5ZogP7NPsqn3lHBxrgmpWuMgAcv3hDdkYHCZ2kVJtl+BrExehfPSpdyYEggrnd2aWNaKGVw4nQgmszWkhgUzwp/yLaYinkMQgB76GgKFcnyEDunij+mt8P/NZthMbhZST0+iA4g26U2XAr8UYlWhg3K9LkFudjAs2JrKxOVHtCAlqwgWXdSb2FU7VUl0OXA/VrAKQtRlLNA8Wwh9sbTFkGORPYj7Ua8v0D//qqpYBkrvwLo+bO36IoOWwzX0+fthhosd/wsxq6JaF18Z2pa53qKCW050xv2eJs6RxBsuMnnmmqU8wwJ5HaQM66s8jl7u4w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6rf7-00011r-LA for guix-patches@gnu.org; Fri, 01 Nov 2024 09:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73842] [PATCH v2 1/3] gnu: appimage: New packages for the appimage runtime. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Nov 2024 13:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?No=C3=A9?= Lopez Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73842@debbugs.gnu.org Received: via spool by 73842-submit@debbugs.gnu.org id=B73842.17304675213872 (code B ref 73842); Fri, 01 Nov 2024 13:26:01 +0000 Received: (at 73842) by debbugs.gnu.org; 1 Nov 2024 13:25:21 +0000 Received: from localhost ([127.0.0.1]:49486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6reS-0000yo-Jp for submit@debbugs.gnu.org; Fri, 01 Nov 2024 09:25:21 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:48129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6reQ-0000pt-E7 for 73842@debbugs.gnu.org; Fri, 01 Nov 2024 09:25:19 -0400 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-720d14c8dbfso498825b3a.0 for <73842@debbugs.gnu.org>; Fri, 01 Nov 2024 06:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730467452; x=1731072252; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u8GT3HNyjt3EPlQvlbL6gJRs1OKb+ovMfacSNJtIx3Y=; b=YjYUogWR8O10Iq9FcgwWPySYI8AzrO1vWOvE0sdrGLDKz3lSUjTZiyhmMF/32uickj fUSLYd+f+6h8+8n8IcdU+L3B6+eUB3r9aa85gHi2euzZGJ8YdKeSjMe2Y+AtKXlg8Zeh uq4Hc4c9IifNRPFGT00QGxX5Q899Ye/DjoDQU7QbCsPb7VYGgoAbrxniVHckk6HEDVHk iArz/96dZZpq5fCbT4ntB7RjRLcnTcpxVM9bdRMe7v2VFoT+1jSxWRJ8YCv+jF/J12hN jjXL+9LRoGjznjwVQ/xbYZFw4c/JOml0yU5Rdqa3+R47Ml8ZrGNSqf5BI4pkZ6HFj4Ky jDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730467452; x=1731072252; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u8GT3HNyjt3EPlQvlbL6gJRs1OKb+ovMfacSNJtIx3Y=; b=pcse8gyeW162kp6P+fl8Nz+iCFcgh0WFs4lRZMEOcJKEUn1zby0lj1DoLrBxldJxmp LZFA22v8zsOAZwLqjPkdx88F3OoORUIoCexwJbRk38g5r15nuiekbByX/1uW69qiGNmD It8q0UEgr675rPPEQ7H3bn3lliGibpi7ZncxbN1go+I3eMoaeLVJnNTt0cetYBw7FuRa B6M2HuuG9EJi12Mvhq3N96np8iOrlSaYVabSF4J6/CWi3wTmURIU+jHo6/W+naoE8E+J +4OBEuAuiZB+6PHAgXXqvJhYlm7QvGXENh0mavXgGJQZo407IiKco8TgFTbe0zeJazuO jKpw== X-Gm-Message-State: AOJu0YwLZZksD7Pv2SpQxIZ4O7DLf0OqGkUtDpj2zauEQf7lZFeG6J3E GWaeiAwvbsbuV+80ZXRkI9ujjMsW/FSfKwY58VF03uDAcYDPim9O X-Google-Smtp-Source: AGHT+IFpnilg2dmWRrzv8j5uvpLjMN9UKV/oZnCByt8/CjAdvM0tv7lNm/quqrExjuq502ad7aeRzw== X-Received: by 2002:a05:6a20:c998:b0:1d9:857a:585c with SMTP id adf61e73a8af0-1db91d89bc3mr8505017637.19.1730467452410; Fri, 01 Nov 2024 06:24:12 -0700 (PDT) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc2c47f1sm2610122b3a.107.2024.11.01.06.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2024 06:24:11 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <0f3279bf893470c70bdd535b81cd95fd108d5d5f.1729963690.git.noelopez@free.fr> ("=?UTF-8?Q?No=C3=A9?= Lopez"'s message of "Sat, 26 Oct 2024 19:28:09 +0200") References: <0f3279bf893470c70bdd535b81cd95fd108d5d5f.1729963690.git.noelopez@free.fr> Date: Fri, 01 Nov 2024 22:24:08 +0900 Message-ID: <87bjyz1407.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 0.18 X-Spam-Score: 0.18 X-Migadu-Queue-Id: 2CF9D7661 X-Migadu-Scanner: mx13.migadu.com X-TUID: tugd3Jm26XU5 Hi, No=C3=A9 Lopez writes: [...] > +(define squashfuse-for-appimage > + (package > + (inherit squashfuse) > + (arguments > + (list > + #:configure-flags #~'("CFLAGS=3D-ffunction-sections -fdata-secti= ons -Os -no-pie" > + "LDFLAGS=3D-static") > + #:phases #~(modify-phases %standard-phases > + (add-after 'install 'install-private-headers > + (lambda _ > + (install-file "fuseprivate.h" > + (string-append #$output > + "/include/squashfu= se/"))))))) > + (inputs (list fuse-for-appimage > + `(,zstd "lib") > + `(,zstd "static") > + `(,zlib "out") > + `(,zlib "static"))))) > Some lines are a bit too long (our coding style says 80 columns max); you could place the gexps starting with #~ on the line below to make things a bit easier. > + > +(define-public appimage-type2-runtime > + (let ((revision "0") > + ;; No releases, just the latest commit. > + (commit "47b665594856b4e8928f8932adcf6d13061d8c30")) > + (package > + (name "appimage-type2-runtime") > + (version (git-version "continuous" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/AppImage/type2-runtime") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0954crhlbapxis96g1s0vfpf78ybr64zvjalak387ksxj560g44x"= )))) > + (arguments > + (list > + #:make-flags #~(list "-Csrc/runtime" "runtime-fuse3" > + (string-append "CFLAGS=3D" > + "-I" > + #$fuse-2 > + "/include/fuse/" > + " -DGIT_COMMIT=3D'\"" > + "guix-" > + #$version > + "\"'" > + " -D_FILE_OFFSET_BITS=3D64" > + " -static")) This feels cramped; start on a new line to give yourself a bit more horizontal width. > + #:modules > + `((guix build gnu-build-system) > + (guix build utils) > + (ice-9 binary-ports)) > + #:phases #~(modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) ; No tests. > + (replace 'install > + (lambda _ > + (install-file "src/runtime/runtime-fuse3" > + (string-append #$output "/bin")))) > + ;; must be after all elf reliant phases > + (add-after 'make-dynamic-linker-cache 'set-magic-by= tes > + (lambda _ > + (let ((port (open (string-append #$output > + "/bin/runtime-fuse3") The indentation is off here. Try running it with 'guix style' or the old Emacs-based indenter to see. > + (logior O_WRONLY)))) > + (seek port 8 SEEK_SET) > + (put-bytevector port #vu8(#x41 #x49 #x02)) > + (close-port port))))) > + #:disallowed-references (list squashfuse-for-appimage > + fuse-for-appimage zstd zlib))) > + ;; only needed at build time As mentioned earlier, please use complete sentences for standalone comments. > + (inputs (list squashfuse-for-appimage fuse-for-appimage > + `(,zstd "static") > + `(,zlib "static"))) > + (build-system gnu-build-system) > + (home-page "https://github.com/AppImage/type2-runtime") > + (synopsis "Runtime for executing AppImages") > + (description "The runtime is the executable part of every AppImage= , it mounts > +the payload via FUSE and executes the entrypoint.") > + (license license:expat)))) --=20 Thanks, Maxim