[bug#74882] [PATCH] scripts: substitute: Refine 'updating substitutes' message.

[bug#74882] [PATCH] scripts: substitute: Refine 'updating substitutes' message.

[Maxim Cournoyer]

* guix/scripts/substitute.scm (process-query): Attempt to precise the 'update
substitutes' message.

Suggested-by: Tobias Geerinckx-Rice <me@tobias.gr>
Reported-by: Felix Lechner <felix.lechner@lease-up.com>
Change-Id: I7b3f93f32b73a6a6175a035a09ab51a6e74e384b
---
 guix/scripts/substitute.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 8db730a9c0..993951e33c 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -328,7 +328,7 @@ (define* (process-query port command
       (erase-current-line (current-error-port)) ;erase current line
       (force-output (current-error-port))
       (format (current-error-port)
-              (G_ "updating substitutes from '~a'... ~5,1f%")
+              (G_ "looking for suitable substitutes on '~a'... ~5,1f%")
               url (* 100. (/ done total)))
       (set! done (+ 1 done)))
 

base-commit: cfd4f56f75a20b6732d463180d211f796c9032e5
-- 
2.46.0

[bug#74882] [PATCH] scripts: substitute: Refine 'updating substitutes' message.

[Ludovic Courtès]

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> * guix/scripts/substitute.scm (process-query): Attempt to precise the 'update
> substitutes' message.

[...]

> -              (G_ "updating substitutes from '~a'... ~5,1f%")
> +              (G_ "looking for suitable substitutes on '~a'... ~5,1f%")

Part of the challenge here is having something that fits on one line,
which is still 80 characters for many (heck, GNOME Console or whatever
it’s called these days, the incarnation of modernity, defaults to 80
columns!).

Ludo’.

[bug#74882] [PATCH] scripts: substitute: Refine 'updating substitutes' message.

[Maxim Cournoyer]

Hello!

Ludovic Courtès <ludo@gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> * guix/scripts/substitute.scm (process-query): Attempt to precise the 'update
>> substitutes' message.
>
> [...]
>
>> -              (G_ "updating substitutes from '~a'... ~5,1f%")
>> +              (G_ "looking for suitable substitutes on '~a'... ~5,1f%")
>
> Part of the challenge here is having something that fits on one line,
> which is still 80 characters for many (heck, GNOME Console or whatever
> it’s called these days, the incarnation of modernity, defaults to 80
> columns!).

In the original case we have 80 - 37 => 43 characters available for the
server URL.

The above diff would reduce that to 33 characters available for the
server URL; that' sill enough for our current default substitute URLs
(https://ci.guix.gnu.org/ is 24 characters, while
https://bordeaux.guix.gnu.org/ is 30 characters) although doesn't leave
much headroom.

We could perhaps shorten to just "looking for substitutes on" (drop the
'suitable ' part) ?  That'd be already an improvement when it comes to
more accurately reports what is actually happening.

-- 
Thanks,
Maxim