From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: tumashu@163.com
Cc: 75044@debbugs.gnu.org
Subject: [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
Date: Mon, 30 Dec 2024 16:56:49 +0800 [thread overview]
Message-ID: <87bjwtsg4u.fsf@iscas.ac.cn> (raw)
In-Reply-To: <20241225030445.14655-1-tumashu@163.com> (tumashu@163.com's message of "Wed, 25 Dec 2024 11:04:42 +0800")
[-- Attachment #1: Type: text/plain, Size: 3628 bytes --]
tumashu@163.com writes:
> From: Feng Shu <tumashu@163.com>
>
> * gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.
>
> Change-Id: I558add1665d79429e2562c2139777002b7a70466
> ---
> gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
> index df5fc0a857..b70f8101e6 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
> GTK+, lets you select a desktop session and log in to it.")
> (license license:gpl3+)))
>
> +(define-public lightdm-mini-greeter
> + (package
> + (name "lightdm-mini-greeter")
> + (version "0.5.1-ead793")
please use git-version, likes:
(define-public lightdm-mini-greeter
(let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
(revision "0"))
(package
...
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/prikhi/lightdm-mini-greeter")
(commit commit)))
(file-name (git-file-name name version))
(sha256
(base32
"17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
...)))
and add comment for why use commit, not git tag.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/prikhi/lightdm-mini-greeter")
> + (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
> + (build-system glib-or-gtk-build-system)
> + (arguments
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'customize-default-config-path
> + (lambda _
> + (substitute* "Makefile.am"
> + ;; Have the default config directory sourced from
> + ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
> + ;; lightdm service writes it.
> + (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
> + "/etc/lightdm/lightdm-mini-greeter.conf"))))
> + (add-after 'install 'fix-.desktop-file
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* (search-input-file
> + outputs
> + "share/xgreeters/lightdm-mini-greeter.desktop")
> + (("Exec=lightdm-mini-greeter")
> + (string-append "Exec="
> + (search-input-file
> + outputs "bin/lightdm-mini-greeter")))))))))
> + (native-inputs
> + (list autoconf automake pkg-config))
> + (inputs
> + (list gtk+ lightdm))
> + (synopsis "Mini Greeter for LightDM")
> + (home-page "https://github.com/prikhi/lightdm-mini-greeter")
> + (description "This package provide a minimal but highly configurable single-user GTK3
> +greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
> +LightDM GTK3 Greeter.")
> + (license license:gpl3)))
> +
> (define-public slim
> (package
> (name "slim")
I didn't compile, test, everything else looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2024-12-30 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87h66uvj1w.fsf@163.com>
2024-12-25 3:04 ` [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter tumashu
2024-12-30 8:56 ` Zheng Junjie [this message]
2024-12-30 13:48 ` Feng Shu
2024-12-30 1:46 ` [bug#75044] Please review this patch Feng Shu
2024-12-30 13:46 ` [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter tumashu
2025-01-02 13:03 ` bug#75044: " Zheng Junjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjwtsg4u.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=75044@debbugs.gnu.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.