From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: New package recipe: libopus-1.1
Date: Wed, 22 Jan 2014 23:39:39 +0100
Message-ID: <87a9enskt0.fsf@gnu.org>
References: <52DFE285.2010206@totakura.in> <52DFE3DD.1020005@gmail.com>
	<52DFED9F.1050404@totakura.in> <20140122205933.GA30625@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41998)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W66XQ-00038q-Lg
	for guix-devel@gnu.org; Wed, 22 Jan 2014 17:44:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W66XL-0005q3-2X
	for guix-devel@gnu.org; Wed, 22 Jan 2014 17:44:48 -0500
Received: from hera.aquilenet.fr ([141.255.128.1]:38359)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1W66XK-0005pv-RR
	for guix-devel@gnu.org; Wed, 22 Jan 2014 17:44:42 -0500
In-Reply-To: <20140122205933.GA30625@debian> (Andreas Enge's message of "Wed,
	22 Jan 2014 21:59:33 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> thanks for the patch, and congratulations for your first guix package
> (which I did not try out yet, I simply assumed it worked...).

Indeed, cool.  :-)

And thanks to the other people for the reviews!

> Actually, it should go into oggvorbis.scm, where we put all xiph codecs.
> Could you please do so and drop the new file, also from gnu-system.am?

Agreed.

> I am not sure about the
>    Signed-off-by: Sree Harsha Totakura <sreeharsha@totakura.in>
> field; normally you are simply the author, no need to add it (and when
> Ludovic applies patches coming from the list, he normally signs them off).

Right.

Note to the reviewers: feel free to push a patch that looks good to you
and uncontroversial, per the guidelines in =E2=80=98HACKING=E2=80=99.  Don=
=E2=80=99t be shy.  ;-)

Ludo=E2=80=99.