[PATCH] gnu: Add fish.

[PATCH] gnu: Add fish.

[David Thompson]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

This patch adds fish, the friendly interactive shell.


[-- Attachment #2: 0001-gnu-Add-fish.patch --]
[-- Type: text/x-diff, Size: 2850 bytes --]

From d050978c818408e845732165c37666562ba04fba Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Thu, 10 Jul 2014 08:07:00 -0400
Subject: [PATCH] gnu: Add fish.

* gnu/packages/fish.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/fish.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 gnu/packages/fish.scm

diff --git a/gnu-system.am b/gnu-system.am
index e25c922..a1a5bda 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -76,6 +76,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/elf.scm				\
   gnu/packages/emacs.scm			\
   gnu/packages/file.scm				\
+  gnu/packages/fish.scm				\
   gnu/packages/flex.scm				\
   gnu/packages/fltk.scm				\
   gnu/packages/fonts.scm			\
diff --git a/gnu/packages/fish.scm b/gnu/packages/fish.scm
new file mode 100644
index 0000000..6868b24
--- /dev/null
+++ b/gnu/packages/fish.scm
@@ -0,0 +1,46 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 David Thompson <davet@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages fish)
+  #:use-module (guix licenses)
+  #:use-module (gnu packages ncurses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu))
+
+(define-public fish
+  (package
+    (name "fish")
+    (version "2.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://fishshell.com/files/"
+                                  version "/fish-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0i7h3hx8iszli3d4kphw79sz9m07f2lc2c9hr9smdps5s7wpllmg"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     '(#:tests? #f)) ; no check target
+    (synopsis "The friendly interactive shell")
+    (description "Fish is a smart and user-friendly command line shell.")
+    (home-page "http://fishshell.com/")
+    (license gpl2)))
-- 
2.0.0


[-- Attachment #3: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: Add fish.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> From d050978c818408e845732165c37666562ba04fba Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Thu, 10 Jul 2014 08:07:00 -0400
> Subject: [PATCH] gnu: Add fish.
>
> * gnu/packages/fish.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

LGTM.

> +    (description "Fish is a smart and user-friendly command line shell.")

Could you add a few words to mention its distinguishing features (those
that appear on the home page)?

OK to commit with this change.

Thanks,
Ludo’.

Re: [PATCH] gnu: Add fish.

[David Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> Could you add a few words to mention its distinguishing features (those
> that appear on the home page)?

Added a slightly modified version of the description on the Free
Software Directory.

Additionally, I've added doxygen as an input in order to build the docs.

Pushed.  Thanks for the review!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate