Re: [PATCH] emacs: Improve interface for working with multiple profiles.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> The main changes are:
>
> - Now default buffer names look like this:
>
>     *Guix Package List: guix-profile*
>     *Guix Package Info: test4*
>
>   i.e., a buffer name contains a name of a profile used by this buffer.

Neat!

> - All commands for displaying generations and packages now can be called
>   with "C-u".  This allows to select a profile just for this command.
>   (The current profile can be changed with
>   "M-x guix-set-current-profile").

Wonderful!  :-)

What about renaming ‘guix-set-current-profile’ to
‘guix-set-default-profile’?  Because now, what it does is just to define
the profile that is used when C-u isn’t used, right?

> Also as prefix argument was previously used in "M-x guix-generations" to
> select last N generations, I added a new command "M-x
> guix-last-generations".

OK.

>  @item M-x guix-generations
> -List generations for the current profile.  With numeric prefix, show so
> -many last generations.
> +List all generations for the current profile.
           ^                    ^^^^^^^
“all the generations”

For all these commands, it may be better to omit “current”, because it’s
not necessary the current/default profile that is used.

> +@item M-x guix-last-generations
> +List last generations for the current profile. You will be prompted for
> +the number of generations.

Maybe: “List the @var{N} last generations of the profile.”
Also, double space after period.

> -By default commands for displaying packages display each output on a
> +All these commands use current profile, which can be changed with
> +@kbd{M-x@tie{}guix-set-current-profile}.  Also if you call any of these
> +commands with prefix argument (@kbd{C-u}), you will be prompted for a
> +profile just for that command.

s/current/default/ ?

I wonder if it might be better to move this paragraph above the first
command, so it’s clear which profile we’re talking about.

> -For example if you want to display all types of results in a single
> +By default, the name of a profile is also displayed in a ``list'' or
> +''info'' buffer name.  To change this behavior, use
   ^^
backquotes

Nothing else to add.  Thanks for being so productive!

Ludo’.