From: 宋文武 <iyzsong@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 11/15] gnu: Add xfce4-settings.
Date: Fri, 12 Dec 2014 20:53:24 +0800 [thread overview]
Message-ID: <87a92t81x7.fsf@gmail.com> (raw)
In-Reply-To: <877fxx1tlx.fsf@netris.org>
Mark H Weaver <mhw@netris.org> writes:
> 宋文武 <iyzsong@gmail.com> writes:
>
>> * gnu/packages/xfce.scm (xfce4-settings): New variable.
>> ---
>> gnu/packages/xfce.scm | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
>> index 5f15594..c601852 100644
>> --- a/gnu/packages/xfce.scm
>> +++ b/gnu/packages/xfce.scm
>> @@ -310,3 +310,33 @@ your system in categories, so you can quickly find and launch them.")
>> "Session manager for Xfce, it will restores your session on startup and
>> allows you to shutdown the computer from Xfce.")
>> (license gpl2+)))
>> +
>> +(define-public xfce4-sesttings
>
> The variable name above has a typo:
> 'xfce4-sesttings' ->
> 'xfce4-settings'.
Oh
>
>> + (package
>> + (name "xfce4-settings")
>> + (version "4.10.0")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "http://archive.xfce.org/xfce/4.10/src/"
>> + name "-" version ".tar.bz2"))
>
> Instead of putting "4.10" directly in the string above, how about this:
>
> (uri (string-append "http://archive.xfce.org/xfce/"
> (version-major+minor version)
> "/src/" name "-" version ".tar.bz2"))
>
> This way, when the package is updated to a new version, there will be
> one less thing to change. The same change could be made to many of your
> other xfce packages.
>
> 'version-major+minor' is in the (guix utils) module, so you'll need to
> add that to the import list.
Adjusted, thanks for review!
>
> Thanks for working on this!
>
> Mark
next prev parent reply other threads:[~2014-12-12 12:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 12:02 [PATCH 01/15] gnu: Add gtk-xfce-engine 宋文武
2014-12-10 12:02 ` [PATCH 02/15] gnu: Add libxfce4util 宋文武
2014-12-11 13:28 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 03/15] gnu: Add xfconf 宋文武
2014-12-11 13:28 ` Ludovic Courtès
2014-12-12 15:28 ` Mark H Weaver
2014-12-13 3:20 ` 宋文武
2014-12-10 12:02 ` [PATCH 04/15] gnu: Add libxfce4ui 宋文武
2014-12-11 13:29 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 05/15] gnu: Add exo 宋文武
2014-12-11 13:30 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 06/15] gnu: Add garcon 宋文武
2014-12-10 12:02 ` [PATCH 07/15] gnu: Add tumbler 宋文武
2014-12-11 13:31 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 08/15] gnu: Add xfce4-panel 宋文武
2014-12-11 13:31 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 09/15] gnu: Add xfce4-appfinder 宋文武
2014-12-11 13:32 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 10/15] gnu: Add xfce4-session 宋文武
2014-12-11 13:32 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 11/15] gnu: Add xfce4-settings 宋文武
2014-12-11 13:33 ` Ludovic Courtès
2014-12-12 2:37 ` Mark H Weaver
2014-12-12 12:53 ` 宋文武 [this message]
2014-12-10 12:02 ` [PATCH 12/15] gnu: Add thunar 宋文武
2014-12-11 13:34 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 13/15] gnu: Add thunar-volman 宋文武
2014-12-11 13:35 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 14/15] gnu: Add xfwm4 宋文武
2014-12-11 13:35 ` Ludovic Courtès
2014-12-10 12:02 ` [PATCH 15/15] gnu: Add xfdesktop 宋文武
2014-12-11 13:36 ` Ludovic Courtès
2014-12-12 12:54 ` 宋文武
2014-12-11 13:27 ` [PATCH 01/15] gnu: Add gtk-xfce-engine Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a92t81x7.fsf@gmail.com \
--to=iyzsong@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.