From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add aalib.
Date: Sat, 04 Apr 2015 23:06:56 +0200
Message-ID: <87a8yniowf.fsf@gnu.org>
References: <1428160188-27419-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56895)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YeVHT-0001u8-9g
	for guix-devel@gnu.org; Sat, 04 Apr 2015 17:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YeVHO-0001mT-9z
	for guix-devel@gnu.org; Sat, 04 Apr 2015 17:07:03 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35736)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YeVHO-0001mN-7y
	for guix-devel@gnu.org; Sat, 04 Apr 2015 17:06:58 -0400
In-Reply-To: <1428160188-27419-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sat, 4 Apr 2015 23:09:48 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/packages/video.scm (aalib): New variable.

[...]

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool"  ,libtool)
> +       ("makeinfo" ,texinfo)))

[...]

> +         ;; Regenerate the configure script to accept assignments of SHE=
LL
> +         ;; and CONFIG_SHELL.
> +         (add-after unpack bootstrap
> +                    (lambda _
> +                      (zero? (system* "autoreconf" "-vfi")))))))

Please don=E2=80=99t do that because it adds big dependencies to the packag=
e.
Instead, could you change it to follow the same approach as in time.scm?

Other than that it LGTM.

Thanks,
Ludo=E2=80=99.