From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add aalib.
Date: Sat, 04 Apr 2015 23:06:56 +0200 [thread overview]
Message-ID: <87a8yniowf.fsf@gnu.org> (raw)
In-Reply-To: <1428160188-27419-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Sat, 4 Apr 2015 23:09:48 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> * gnu/packages/video.scm (aalib): New variable.
[...]
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ("makeinfo" ,texinfo)))
[...]
> + ;; Regenerate the configure script to accept assignments of SHELL
> + ;; and CONFIG_SHELL.
> + (add-after unpack bootstrap
> + (lambda _
> + (zero? (system* "autoreconf" "-vfi")))))))
Please don’t do that because it adds big dependencies to the package.
Instead, could you change it to follow the same approach as in time.scm?
Other than that it LGTM.
Thanks,
Ludo’.
prev parent reply other threads:[~2015-04-04 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 15:09 [PATCH] gnu: Add aalib 宋文武
2015-04-04 21:06 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8yniowf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.