From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 3/4] emacs: Move guix-guile-program to 'guix-config'.
Date: Fri, 07 Aug 2015 10:21:39 +0300
Message-ID: <87a8u3sgvw.fsf@gmail.com>
References: <1438033720-30958-1-git-send-email-mthl@openmailbox.org>
	<1438033720-30958-4-git-send-email-mthl@openmailbox.org>
	<87oaivl5ro.fsf@gmail.com> <87a8u4z4hb.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZNbyO-0001Rs-Nc
	for guix-devel@gnu.org; Fri, 07 Aug 2015 03:21:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZNbyJ-0004BJ-Ov
	for guix-devel@gnu.org; Fri, 07 Aug 2015 03:21:48 -0400
Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:36430)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZNbyJ-0004BC-GD
	for guix-devel@gnu.org; Fri, 07 Aug 2015 03:21:43 -0400
Received: by lagz9 with SMTP id z9so17092843lag.3
	for <guix-devel@gnu.org>; Fri, 07 Aug 2015 00:21:42 -0700 (PDT)
In-Reply-To: <87a8u4z4hb.fsf@openmailbox.org> (Mathieu Lirzin's message of
	"Thu, 06 Aug 2015 19:55:28 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org

Thank you, all 3 patches look good to me.  I think you can commit them.

Mathieu Lirzin (2015-08-06 20:55 +0300) wrote:

> diff --git a/emacs/guix-config.el.in b/emacs/guix-config.el.in
> index 8804f72..0ab97e2 100644
> --- a/emacs/guix-config.el.in
> +++ b/emacs/guix-config.el.in
> @@ -22,6 +22,15 @@
>  (defconst guix-emacs-interface-directory
>    (replace-regexp-in-string "${prefix}" "@prefix@" "@emacsuidir@"))
>=20=20
> +(defvar guix-guile-program "@GUILE@"
> +  "Name of the guile executable used for Guix REPL.
> +May be either a string (the name of the executable) or a list of
> +strings of the form:
> +
> +  (NAME . ARGS)
> +
> +Where ARGS is a list of arguments to the guile program.")
> +
>  (defconst guix-state-directory
>    ;; This must match `NIX_STATE_DIR' as defined in `daemon.am'.
>    (or (getenv "NIX_STATE_DIR") "@guix_localstatedir@/guix"))

I would rather add 'guix-guile-program' after both 'guix-=E2=80=A6-director=
y'
constants, but it doesn't really matter.

--=20
Alex