From: Andy Wingo <wingo@igalia.com>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Simplify LLVM build.
Date: Mon, 17 Aug 2015 15:56:00 +0200 [thread overview]
Message-ID: <87a8tqnhn3.fsf@igalia.com> (raw)
In-Reply-To: <20150817034338.5918ffdd@openmailbox.org> (Eric Bavier's message of "Mon, 17 Aug 2015 03:43:38 -0500")
On Mon 17 Aug 2015 10:43, Eric Bavier <ericbavier@openmailbox.org> writes:
> Hello Andy,
>
> Thanks for taking a closer look at this!
>
> On Mon, 17 Aug 2015 08:27:38 +0200
> Andy Wingo <wingo@igalia.com> wrote:
>
>> From db066d194d3b8359eddd0149234bfad29c11542d Mon Sep 17 00:00:00 2001
>> From: Andy Wingo <wingo@igalia.com>
>> Date: Mon, 17 Aug 2015 08:26:07 +0200
>> Subject: [PATCH] gnu: Simplify LLVM build.
>>
>> * gnu/packages/llvm.scm (llvm): Simplify build.
>
> Could this perhaps be a bit more descriptive? It also doesn't
> follow our standard. Maybe:
>
> gnu: llvm: Simplify build rpath handling.
>
> * gnu/packages/llvm.scm (llvm)[arguments]: Remove phases argument.
> Add to configure-flags "-DCMAKE_SKIP_BUILD_RPATH=FALSE" and
> "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE".
>
> `~Eric
It could :) However I do not see how the change you mention would be
indicated by the GCS, HACKING, or guix.texi. As per the GCS I think
this falls under "simple changes". If Guix has additional requirements
they should be indicated somewhere; did I miss the document?
Cheers,
Andy
next prev parent reply other threads:[~2015-08-17 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 6:27 [PATCH] gnu: Simplify LLVM build Andy Wingo
2015-08-17 8:43 ` Eric Bavier
2015-08-17 13:56 ` Andy Wingo [this message]
2015-08-21 21:16 ` Mark H Weaver
2015-08-24 7:46 ` Andy Wingo
2015-08-24 15:50 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8tqnhn3.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.