From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 2/2] gnu: Add d-feet.
Date: Sat, 22 Aug 2015 01:32:50 -0400
Message-ID: <87a8tj6g71.fsf@netris.org>
References: <1440060104-29551-1-git-send-email-iyzsong@gmail.com>
	<1440060104-29551-2-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56357)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZT1QZ-00041m-RE
	for guix-devel@gnu.org; Sat, 22 Aug 2015 01:33:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZT1QW-0003bd-LS
	for guix-devel@gnu.org; Sat, 22 Aug 2015 01:33:15 -0400
Received: from world.peace.net ([50.252.239.5]:42802)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1ZT1QW-0003bZ-Io
	for guix-devel@gnu.org; Sat, 22 Aug 2015 01:33:12 -0400
In-Reply-To: <1440060104-29551-2-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Thu, 20 Aug 2015 16:41:44 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

One more thing:

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> writes:
> +       (modify-phases %standard-phases
> +         (add-before
> +          'check 'pre-check
> +          (lambda* (#:key inputs #:allow-other-keys)
> +            ;; The test suite requires a running X server.
> +            (system (format #f "~a/bin/Xvfb :1 &"
> +                            (assco-ref inputs "xorg-server")))
> +            (setenv "DISPLAY" ":1")
> +            ;; Don't fail on missing '/etc/machine-id'.
> +            (setenv "DBUS_FATAL_WARNINGS" "0")
> +            ;; tests.py and window.py don't meet E402:
> +            ;;   E402 module level import not at top of file
> +            (substitute* "src/tests/Makefile"
> +              (("--ignore=3DE123") "--ignore=3DE123,E402"))))

I forgot to mention that you should add #t here, since phase procedures
are supposed to return a boolean, but the return value of 'substitute*'
is unspecified.

     Thanks,
       Mark