From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] system: Make PAM use SHA-512 to encrypt passwords.
Date: Sun, 23 Aug 2015 23:36:23 +0200
Message-ID: <87a8thwuug.fsf@gnu.org>
References: <1440253728-27346-1-git-send-email-iyzsong@gmail.com>
	<87io87iczk.fsf@gmail.com> <87a8tjrzwi.fsf@netris.org>
	<87bndzymd9.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZTcwI-0003gG-UN
	for guix-devel@gnu.org; Sun, 23 Aug 2015 17:36:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZTcwD-0001To-Uk
	for guix-devel@gnu.org; Sun, 23 Aug 2015 17:36:30 -0400
In-Reply-To: <87bndzymd9.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sun, 23 Aug 2015 06:44:18 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> From 34a324e398c521954cc275211eabd44a92906aad Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyzs=
ong@gmail.com>
> Date: Sun, 23 Aug 2015 06:33:59 +0800
> Subject: [PATCH] system: Make PAM store SHA-512 encrypted passwords in
>  /etc/shadow.
>
> Fixes <http://bugs.gnu.org/21318>.
>
> * gnu/system/linux.scm (unix-pam-service)[password]: Add 'sha512' and
>   'shadow' to arguments.

[...]

> -         (password (list unix))
> +         (password (list (pam-entry
> +                          (control "required")
> +                          (module "pam_unix.so")
> +                          (arguments '("sha512" "shadow")))))

One last thing: a one-line comment explaining what these arguments do.
Then OK to push ASAP!

Thanks to both of you!

Ludo=E2=80=99.