From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 3/3] gnu: Add Attic.
Date: Sun, 30 Aug 2015 22:58:06 +0300
Message-ID: <87a8t88s6p.fsf@gmail.com>
References: <cover.1440609350.git.leo@famulari.name>
	<4debbb251087c71a9c19e16b84bda6e5ed059097.1440609350.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8jv-0007To-Ci
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8js-0001Bo-5F
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:58:07 -0400
Received: from mail-lb0-x231.google.com ([2a00:1450:4010:c04::231]:34021)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8jr-0001BJ-T3
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:58:04 -0400
Received: by lbbtg9 with SMTP id tg9so50863710lbb.1
	for <guix-devel@gnu.org>; Sun, 30 Aug 2015 12:58:03 -0700 (PDT)
In-Reply-To: <4debbb251087c71a9c19e16b84bda6e5ed059097.1440609350.git.leo@famulari.name>
	(Leo Famulari's message of "Wed, 26 Aug 2015 13:16:27 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari (2015-08-26 20:16 +0300) wrote:

> +(define-public attic
> +  (package
> +   (name "attic")
> +   (version "0.16")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://pypi.python.org/packages/source/A/Attic/Attic-"
> +                   version ".tar.gz"))
> +            (sha256
> +             (base32 "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36"))))
> +   (build-system python-build-system)
> +   (arguments
> +    `(#:phases (modify-phases %standard-phases
> +     (add-before
> +      'build 'set-openssl-prefix
> +      (lambda* (#:key inputs #:allow-other-keys)
> +        (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
> +        #t)))))

Please align modify-phases clause like this:

(modify-phases %standard-phases
  (add-before
   'build 'set-openssl-prefix
   (lambda* (#:key inputs #:allow-other-keys)
     (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
     #t)))

The rest LGTM, thank you.

-- 
Alex