From: Mark H Weaver <mhw@netris.org>
To: Steve Sprang <steve.sprang@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] build: Fix potential type error when generating human-friendly byte count strings.
Date: Wed, 09 Sep 2015 22:42:55 -0400 [thread overview]
Message-ID: <87a8svuh8w.fsf@netris.org> (raw)
In-Reply-To: <CA+xn8YCMk5tJjB_rEFEPwWm4ef3enCuRJ03PR1f8bH8TvGrUwQ@mail.gmail.com> (Steve Sprang's message of "Wed, 9 Sep 2015 14:05:35 -0700")
Steve Sprang <steve.sprang@gmail.com> writes:
> This is a follow up tweak to my previous "progress bar" patch. With a
> really slow throughput it's possible to get fractional sub-KiB byte
> counts, so I added some additional number massaging.
Sounds good! Looks good to me except for a few minor nits on this
auxiliary procedure:
> +(define (number->integer n)
> + "Given an arbitrary number N, round it and return the exact result."
> + (inexact->exact (round n)))
How about calling it "nearest-exact-integer"? Also, it makes sense only
for real numbers, not arbitrary numbers, and the variable name N is
conventionally used to denote natural numbers, and X for real numbers.
So, how about naming the argument 'x', and using something closer to the
following docstring:
"Given a real number X, return the nearest exact integer, with ties
going to the nearest exact even integer."
Otherwise, looks good to me. Can you send an updated patch?
Mark
next prev parent reply other threads:[~2015-09-10 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 21:05 [PATCH] build: Fix potential type error when generating human-friendly byte count strings Steve Sprang
2015-09-10 2:42 ` Mark H Weaver [this message]
2015-09-10 3:31 ` Steve Sprang
2015-09-15 3:27 ` Steve Sprang
2015-09-15 3:40 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8svuh8w.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=steve.sprang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.