From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH 1/3] gnu: Add python-pip.
Date: Tue, 22 Sep 2015 16:30:42 +0200
Message-ID: <87a8se4jcd.fsf@openmailbox.org>
References: <1442874675-31473-1-git-send-email-tipecaml@gmail.com>
	<1442874675-31473-2-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZeOaw-0007z9-9Z
	for guix-devel@gnu.org; Tue, 22 Sep 2015 10:31:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZeOas-0003ww-TG
	for guix-devel@gnu.org; Tue, 22 Sep 2015 10:30:58 -0400
Received: from smtp5.openmailbox.org ([62.4.1.39]:54495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZeOas-0003tW-2t
	for guix-devel@gnu.org; Tue, 22 Sep 2015 10:30:54 -0400
In-Reply-To: <1442874675-31473-2-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Tue, 22 Sep 2015 00:31:13 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/python.scm (python-pip, python2-pip): New variables.
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

[...]

> +    (home-page "https://pip.pypa.io/")
> +    (synopsis
> +      "The PyPA recommended tool for installing Python packages")
                   ^^^

IMO Pypa recommandations are not relevant in Guix context.  What about
something more neutral like =E2=80=9CXenophobic package manager=E2=80=9D? ;=
) Just
kidding.

I would prefer=20

    (synopsis "Package manager for Python software")

> +    (description
> +      "Pip is a package manager for Python software, that finds packages=
 on the
> +Python Package Index (PyPI).")

It would be nice to have a more verbose description, for example
describing its main features...  Sorry I can't help much :)

> +    (license license:expat)))
> +
> +(define-public python2-pip
> +  (package-with-python2 python-pip))

Otherwise LGTM!

--
Mathieu Lirzin