From: Mathieu Lirzin <mthl@openmailbox.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add python-pip.
Date: Tue, 22 Sep 2015 16:30:42 +0200 [thread overview]
Message-ID: <87a8se4jcd.fsf@openmailbox.org> (raw)
In-Reply-To: <1442874675-31473-2-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Tue, 22 Sep 2015 00:31:13 +0200")
Cyril Roelandt <tipecaml@gmail.com> writes:
> * gnu/packages/python.scm (python-pip, python2-pip): New variables.
> ---
> gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
[...]
> + (home-page "https://pip.pypa.io/")
> + (synopsis
> + "The PyPA recommended tool for installing Python packages")
^^^
IMO Pypa recommandations are not relevant in Guix context. What about
something more neutral like “Xenophobic package manager”? ;) Just
kidding.
I would prefer
(synopsis "Package manager for Python software")
> + (description
> + "Pip is a package manager for Python software, that finds packages on the
> +Python Package Index (PyPI).")
It would be nice to have a more verbose description, for example
describing its main features... Sorry I can't help much :)
> + (license license:expat)))
> +
> +(define-public python2-pip
> + (package-with-python2 python-pip))
Otherwise LGTM!
--
Mathieu Lirzin
next prev parent reply other threads:[~2015-09-22 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 22:31 [PATCH 0/3] Add python-bandit Cyril Roelandt
2015-09-21 22:31 ` [PATCH 1/3] gnu: Add python-pip Cyril Roelandt
2015-09-22 14:30 ` Mathieu Lirzin [this message]
2015-09-21 22:31 ` [PATCH 2/3] gnu: Update python-fixtures Cyril Roelandt
2015-09-22 15:11 ` Mathieu Lirzin
2015-09-22 19:16 ` Thompson, David
2015-09-22 21:45 ` Cyril Roelandt
2015-09-27 20:17 ` Ludovic Courtès
2015-10-08 21:41 ` Cyril Roelandt
2015-10-09 12:18 ` Ludovic Courtès
2015-09-21 22:31 ` [PATCH 3/3] gnu: Add python-bandit Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8se4jcd.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.