Re: [PATCH] openblas on MIPS.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> I tried building OpenBLAS on one of the MIPS build slaves and it went
> through the build phase without errors when I set the TARGET to
> SICORTEX.  Unfortunately, this doesn’t mean that OpenBLAS actually works
> on MIPS: one of the tests fails.
>
> Meanwhile OpenBLAS version 0.2.15 was released and I just updated our
> package.  It may well be that this bug has already been fixed by the new
> release.
>
> At any rate, I think the two attached patches (one to pass
> TARGET=SICORTEX on MIPS; another to enable substitutes for MIPS) are an
> improvement.  We can use substitutes for MIPS (and ARM for that matter)
> only when TARGET is specified.  The only MIPS target that seems to work
> for us appears to be SICORTEX as the other supported targets use
> Loongson extensions.

Nice!

> From 5132d4f9a36e65439b1295c672ad41364016e6a9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 29 Oct 2015 15:42:09 +0100
> Subject: [PATCH 1/2] gnu: openblas: Set TARGET to SICORTEX on MIPS.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=SICORTEX" to
>   make-flags when building for MIPS.

Sounds good but…

> -                   '("DYNAMIC_ARCH=1")
> -                   ;; On MIPS we force the SICORTEX TARGET, as for the other
> -                   ;; two available MIPS targets special Loongson extended
> -                   ;; instructions are used.
> -                   (if (string-prefix? "mips" (%current-system))
> -                       '("TARGET=SICORTEX")

This doesn’t seem to be a patch against master, is it?

> From b281c60fe666082040097c0d585e942fa5fa1550 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 29 Oct 2015 15:43:21 +0100
> Subject: [PATCH 2/2] gnu: openblas: Make substitutable on MIPS.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Make package
>   substitutable when the system is MIPS.

OK.

Thanks for the tireless investigation work!

Ludo’.