From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 6/6] gnu: Add emacs-slime.
Date: Thu, 31 Dec 2015 13:17:23 +0300
Message-ID: <87a8oqgbws.fsf@gmail.com>
References: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1aEaIR-0001hV-FE
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:17:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1aEaIM-0005qF-F1
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:17:27 -0500
Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:34237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1aEaIM-0005pb-7Q
	for guix-devel@gnu.org; Thu, 31 Dec 2015 05:17:22 -0500
Received: by mail-lf0-x236.google.com with SMTP id y184so237466196lfc.1
	for <guix-devel@gnu.org>; Thu, 31 Dec 2015 02:17:22 -0800 (PST)
In-Reply-To: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
	(Federico Beffa's message of "Wed, 30 Dec 2015 18:33:40 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa (2015-12-30 20:33 +0300) wrote:

[...]
> +(define-public emacs-slime
> +  (package
> +    (name "emacs-slime")
> +    (version "2.15")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/slime/slime/archive/v"
> +             version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0l2z6l2xm78mhh0nczkrmzh2ddb1n911ij9xb6q40zwvx4f8blds"))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("texlive" ,texlive)
> +       ("texinfo" ,texinfo)))

As these inputs are used just for generating documentation, I think they
should be in 'native-inputs'.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'install 'configure
> +           (lambda* _
> +             (substitute* "slime.el"
> +               (("inferior-lisp-program \"lisp\"")
> +                "inferior-lisp-program \"sbcl\""))
> +             #t))

Why do you name this phase 'configure'?  Actually I think this phase is
not needed, because 'inferior-lisp-program' should be set by a user to
whatever implementation (s)he prefers.

Thanks for packaging slime!

-- 
Alex