Re: [PATCH] Update Ruby to 2.3.0 (was Re: Freezing core-updates soon)

[ludo@gnu.org (Ludovic Courtès)]

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> I had some trouble downloading dependencies because of inability to
> download sources e.g. http://graphviz.org/ seems to be down. Ruby
> seems to build though, can we just review as normal and then push to
> core-updates?
>
> I did rebuild all the packages in ruby.scm, and out of these about 1/3
> of packages failed to build, because at least these three packages'
> tests fail
> * yard
> * power_assert
> * minitest_tu_shim
>
> The first two presumably will be fixed upstream soon, but the third
> hasn't seen a release since Aug 2013, and the homepage listed on
> rubygems is dead. I guess we just have to encourage the only package
> we have packaged that uses tu_shim (term-ansicolor) to stop relying on
> it.

OK, thanks for testing this thoroughly.  It would be good to fix these 3
packages sometime before core-updates is merged.

> From cd8c4e078cb930d1ce928b3c614b2081ec6719ac Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Mon, 4 Jan 2016 09:38:42 +1000
> Subject: [PATCH] gnu: ruby: Update to 2.3.0.
>
> * gnu/packages/ruby.scm (ruby): Update to 2.3.0.
> (ruby-2.2): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-before 'configure 'replace-bin-sh
> +           (lambda _
> +             (substitute* '("Makefile.in"
> +                            "ext/pty/pty.c"
> +                            "io.c"
> +                            "lib/mkmf.rb"
> +                            "process.c"
> +                            "test/rubygems/test_gem_ext_configure_builder.rb"
> +                            "test/rdoc/test_rdoc_parser.rb"
> +                            "test/ruby/test_rubyoptions.rb"
> +                            "test/ruby/test_process.rb"
> +                            "test/ruby/test_system.rb"
> +                            "tool/rbinstall.rb")
> +               (("/bin/sh") (which "sh")))
> +             (substitute* "ext/fiddle/libffi-3.2.1/configure"
> +               (("SHELL = /bin/sh")
> +                (string-append "SHELL = " (which "sh"))))
> +             #t)))))
> +    (inputs
> +     `(("readline" ,readline)
> +       ("openssl" ,openssl)
> +       ("libffi" ,libffi)
> +       ("gdbm" ,gdbm)
> +       ("zlib" ,zlib)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "GEM_PATH")
> +            (files (list (string-append "lib/ruby/gems/"
> +                                        (version-major+minor version)
> +                                        ".0"))))))

This seems to be shared with 2.2.  Is it possible to avoid duplication
using something like:

  (define ruby
    (package
      (inherit ruby-2.2)
      (version "2.3.4")
      ;; …
      ))

?

Thanks,
Ludo’.