Re: [PATCH] gnu: boost: Update to 1.60.0

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@openmailbox.org> skribis:

> This patch updates our boost package to version 1.60.0.  It also fixes
> several dependent packages to build with this later version.  I've
> been able to verify the x86-64 builds for all packages in `guix
> refresh -l 
> boost`, except for several packages that already fail to build in
> current master (e.g. opam, simple-scan, strigi, hydra, shogun).

Cool!

> From 29771c37c9f9e304d50921d95fc250131396ea7c Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Tue, 5 Jan 2016 16:09:27 -0600
> Subject: [PATCH] gnu: boost: Update to 1.60.0.
>
> * gnu/packages/boost.scm (boost): Update to 1.60.0.
>   [source]: Remove patch.
> * gnu/packages/patches/boost-mips-avoid-m32.patch: Delete patch
> * gnu-system.am (dist_patch_DATA): Remove patch.
>
> Also fix dependent packages:
>
> * gnu/packages/patches/csound-header-ordering.patch: New patch.
> * gnu/packages/audio.scm (csound)[source]: Use it.
>   [arguments]: Add 'set-flags phase.
> * gnu/packages/patches/libcmis-fix-test-onedrive.patch: New patch.
> * gnu/packages/libreoffice.scm (libcmis)[source]: Use it.
>   (libreoffice)[arguments]: Add LDFLAGS to #:configure-flags.
>   (librevenge)[inputs]: Move boost from here...
>   [propogated-inputs]: to here.
>   [arguments]: Add LDFLAGS to #:configure-flags.
> * gnu/packages/patches/openimageio-boost-1.60.patch: New patch.
> * gnu/packages/graphics.scm (openimageio): Use it.
> * gnu-system.am (dist_patch_DATA): Add patches.

LGTM!  Impressive work on tracking down issues in dependent packages.

> diff --git a/gnu/packages/patches/boost-mips-avoid-m32.patch b/gnu/packages/patches/boost-mips-avoid-m32.patch
> deleted file mode 100644
> index 811c9fb..0000000
> --- a/gnu/packages/patches/boost-mips-avoid-m32.patch
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -The following patch prevents the use of the -m32 flag on mips, where it
> -is not understood by gcc, as well as other non-x86 architectures.
> -
> -diff -u -r boost_1_58_0.orig/tools/build/src/tools/gcc.jam boost_1_58_0/tools/build/src/tools/gcc.jam
> ---- boost_1_58_0.orig/tools/build/src/tools/gcc.jam	2015-04-04 19:25:07.000000000 +0200
> -+++ boost_1_58_0/tools/build/src/tools/gcc.jam	2015-07-10 01:08:19.822733823 +0200
> -@@ -451,7 +451,7 @@
> -         else
> -         {
> -             local arch = [ feature.get-values architecture : $(properties) ] ;
> --            if $(arch) != arm
> -+            if $(arch) = x86

Do you know if this patch or something equivalent was applied upstream?

I guess we’ll have to wait for Hydra’s feedback on MIPS.

Thank you!

Ludo’.