From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add fxtract.
Date: Mon, 11 Jan 2016 22:00:17 +0100
Message-ID: <87a8obg7by.fsf@gnu.org>
References: <568D8BB1.9040001@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIjZh-0001NG-1L
	for guix-devel@gnu.org; Mon, 11 Jan 2016 16:00:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIjZd-0003cS-1f
	for guix-devel@gnu.org; Mon, 11 Jan 2016 16:00:24 -0500
In-Reply-To: <568D8BB1.9040001@uq.edu.au> (Ben Woodcroft's message of "Thu, 7
	Jan 2016 07:48:33 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From acd310d27c457139d3f2fcd2cfc1127167bf2c48 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Thu, 7 Jan 2016 07:44:58 +1000
> Subject: [PATCH] gnu: Add fxtract.
>
> * gnu/packages/bioinformatics.scm (fxtract): New variable.

[...]

> +       `(("ctskennerton-util"
> +          ,(origin
> +             (method git-fetch)
> +             (uri (git-reference
> +                   (url "https://github.com/ctSkennerton/util.git")
> +                   (commit util-commit)))

This is GPLv2-only.  Could you mention it in a comment?

> +             (file-name (string-append
> +                         "ctstennerton-util-" util-commit "-checkout"))

I would make it:

  (string-append "ctstennerton-util-" (string-take util-commit 7)
                 "-checkout")

> +      (home-page "https://github.com/ctSkennerton/fxtract")
> +      (synopsis "Extract sequences from FASTA and FASTQ files")
> +      (description
> +       "Fxtract extracts sequences from a protein or nucleotide fastx (F=
ASTA
> +or FASTQ) file given a subsequence.  It uses a simple substring search f=
or
> +basic tasks but can change to using POSIX regular expressions, PCRE, hash
> +lookups or multi-pattern searching as required.  By default fxtract look=
s in
> +the sequence of each record but can also be told to look in the header,
> +comment or quality sections.")
> +      (license license:gpl3+))))

According to the =E2=80=98LICENSE=E2=80=99 file, this should be =E2=80=98li=
cense:expat=E2=80=99.

Otherwise LGTM.

Thanks,
Ludo=E2=80=99.