From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/6] guix system: Export <boot-parameters> accessors.
Date: Wed, 13 Jan 2016 23:33:37 +0100 [thread overview]
Message-ID: <87a8o9154u.fsf@gnu.org> (raw)
In-Reply-To: <87r3hl9pkv.fsf@gmail.com> (Alex Kost's message of "Wed, 13 Jan 2016 23:44:48 +0300")
Alex Kost <alezost@gmail.com> skribis:
> Ludovic Courtès (2016-01-12 23:25 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> * guix/scripts/system.scm (read-boot-parameters, boot-parameters)
>>> (boot-parameters?, boot-parameters-label, boot-parameters-root-device)
>>> (boot-parameters-kernel, boot-parameters-kernel-arguments): Export.
>>
>> LGTM.
>>
>> Eventually (as a replacement of this patch or as a subsequent patch, as
>> you prefer) we should move these to (gnu system) since this is where we
>> create the ‘boot-parameters’ sexp.
>
> Great, I would like to make a replacement. OK for the attached patch?
>
> (I exported <boot-parameters> because it is used by (guix scripts system))
I usually avoid exporting record type descriptors (RTDs) like
<boot-parameters> because then, if you change the layout of fields, you
have to update every ‘match’ clause out there, and it can be tedious and
error-prone. Also, if the RTD is exported, then it’s trivial for other
modules to forge records of that type.
Could you instead rewrite the two occurrences in (guix system scripts)
so they use the ‘boot-parameters-XYZ’ accessors instead of ‘match’? A
bit more verbose, but safer.
Sorry that I didn’t clarify this before!
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-01-13 22:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 9:53 [PATCH 0/6] emacs: Add "M-x guix-system-generations" Alex Kost
2016-01-10 9:53 ` [PATCH 1/6] guix system: Export <boot-parameters> accessors Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-13 20:44 ` Alex Kost
2016-01-13 22:33 ` Ludovic Courtès [this message]
2016-01-14 8:34 ` Alex Kost
2016-01-14 13:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 2/6] emacs: profiles: Add 'guix-system-profile' Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 3/6] emacs: Find packages in system profiles Alex Kost
2016-01-12 20:28 ` Ludovic Courtès
2016-01-13 20:45 ` Alex Kost
2016-01-13 22:42 ` Ludovic Courtès
2016-01-14 8:38 ` Alex Kost
2016-01-14 13:27 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 4/6] emacs: Replace 'generation-diff' search with 'profile-diff' Alex Kost
2016-01-12 20:29 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 5/6] emacs: Remove 'generation' search type Alex Kost
2016-01-12 20:31 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 6/6] emacs: Add interface for system generations Alex Kost
2016-01-12 20:35 ` Ludovic Courtès
2016-01-13 20:56 ` Alex Kost
2016-01-13 22:44 ` Ludovic Courtès
2016-01-12 20:23 ` [PATCH 0/6] emacs: Add "M-x guix-system-generations" Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8o9154u.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.