From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: Re: [PATCH 12/18] gnu: Add python-anyjson. Date: Sun, 21 Feb 2016 18:54:26 -0800 Message-ID: <87a8mt4fq5.fsf@dustycloud.org> References: <87a8n1sg7l.fsf@dustycloud.org> <877fi0nm7r.fsf@dustycloud.org> <20160220043720.GB14995@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgdp-0004n6-Mt for guix-devel@gnu.org; Sun, 21 Feb 2016 21:54:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXgdo-0001K6-IX for guix-devel@gnu.org; Sun, 21 Feb 2016 21:54:29 -0500 Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:53934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgdo-0001K2-3s for guix-devel@gnu.org; Sun, 21 Feb 2016 21:54:28 -0500 In-reply-to: <20160220043720.GB14995@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Fri, Feb 19, 2016 at 06:34:39PM -0800, Christopher Allan Webber wrote: >> Updated. >> > >> From be98d30d19451a7676a178f017f97173c5d6d29c Mon Sep 17 00:00:00 2001 >> From: Christopher Allan Webber >> Date: Sun, 14 Feb 2016 12:16:49 -0800 >> Subject: [PATCH 11/18] gnu: Add python-anyjson. >> >> * gnu/packages/python.scm (python-anyjson, python2-anyjson): New variables. >> --- >> gnu/packages/python.scm | 39 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 65bf70d..7ce4f09 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -7857,3 +7857,42 @@ minimum of WSGI.") >> (inherit webtest) >> (native-inputs `(("python2-setuptools" ,python2-setuptools) >> ,@(package-native-inputs webtest)))))) >> + >> +(define-public python-anyjson >> + (package >> + (name "python-anyjson") >> + (version "0.3.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "anyjson" version)) >> + (sha256 >> + (base32 >> + "1fjph4alvcscsl5d4b6qpv1yh31jy05jxi1l0xff7lws7j32v09p")))) >> + (build-system python-build-system) >> + (arguments >> + `(;; We could possibly get tests working, but on Python 3 it's not so easy. >> + ;; Very strangely, 2to3 is run *during setup.py install* (or bdist, or >> + ;; whatever) so this transformation needs to be done before the tests >> + ;; can be run. Maybe we could add a build step to transform beforehand >> + ;; but it could be annoying/difficult. >> + ;; We can enable tests for the Python 2 version, though, and do below. >> + #:tests? #f)) >> + (home-page "http://bitbucket.org/runeh/anyjson/") >> + (synopsis >> + "Wraps best available JSON implementation in a common interface") >> + (description >> + "Anyjson loads whichever is the fastest JSON module installed >> +and provides a uniform API regardless of which JSON implementation is used.") >> + (license bsd-3) >> + (properties `((python2-variant . ,(delay python2-anyjson)))))) >> + >> +(define-public python2-anyjson >> + (package >> + (inherit (package-with-python2 >> + (strip-python2-variant python-anyjson))) >> + (arguments `(;; Unlike the python 3 variant, we do run tests. See above! >> + #:tests? #t >> + #:python ,python-2)) > > How about referring to the package-arguments of python-anyjson, like you > did in python2-amqp, rather than specifying the python-version? Or does > that not work? Good idea. Will push with that change when I push the rest (hopefully) tonight.