From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: font-gnu-freefont-ttf: Update to 20120503 and build from source. Date: Thu, 31 Mar 2016 09:48:53 +0200 Message-ID: <87a8lfdr4q.fsf@gnu.org> References: <87k2kmn2jk.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alXLh-0000KD-Ir for guix-devel@gnu.org; Thu, 31 Mar 2016 03:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alXLd-0002R4-08 for guix-devel@gnu.org; Thu, 31 Mar 2016 03:49:01 -0400 In-Reply-To: (=?utf-8?Q?=22al=C3=ADrio?= eyng"'s message of "Tue, 29 Mar 2016 03:38:04 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?Q?al=C3=ADrio?= eyng Cc: guix-devel@gnu.org al=C3=ADrio eyng skribis: >>> * gnu/packages/fonts.scm (font-gnu-freefont-ttf): Update to 20120503. >>> [arguments]: Build from source. >>> * guix/gnu-maintenance.scm (%tarball-rx): Remove comment. >> Not clear, how about =E2=80=9CRemove comment about freefont-ttf.=E2=80= =9D? > ok >>> [=E2=80=A6] >>> + (native-inputs `(("fontforge" ,(package (inherit fontforge) >>> + (inputs `(("python-2" ,python-2) >>> + ,@(package-inputs fontforge))))))) >> Why not add =E2=80=98python-2=E2=80=99 to the fontforge package directly? > see inline references in the updated patch > > From ab7a628f7d8fc9f68f0ebfdd27b3bcb32a607724 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?al=3DC3=3DADrio=3D20eyng?=3D > Date: Tue, 29 Mar 2016 03:32:58 +0000 > Subject: [PATCH] gnu: font-gnu-freefont-ttf: Update to 20120503 and build= from > source. > > * gnu/packages/fonts.scm (font-gnu-freefont-ttf): Update to 20120503. > [arguments]: Build from source. > * guix/gnu-maintenance.scm (%tarball-rx): Remove comment about freefont-t= tf. [...] > + ;; https://github.com/fontforge/fontforge/pull/109 > + ;; "fontforge has to be compiled against only one python version" > + ;; https://github.com/fontforge/fontforge/issues/1731 > + ;; "default python version that fontforge links with is python 2" > + (native-inputs `(("fontforge" ,(package (inherit fontforge) > + (inputs `(("python-2" ,python-2) > + ,@(package-inputs fontforge))))))) I understand cannot support Python 2 and 3 simultaneously, but I think Leo was suggesting changing the =E2=80=98fontforge=E2=80=99 package to use = Python 2.x instead of 3.x. WDYT? Also, could you explain why we need fontforge-with-python2 instead of fontforge-with-python3? > diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm > index 9d720ca..eb9dcf8 100644 > --- a/guix/gnu-maintenance.scm > +++ b/guix/gnu-maintenance.scm > @@ -243,7 +243,6 @@ stored." > (substring tarball 0 end))) >=20=20 > (define %tarball-rx > - ;; The .zip extensions is notably used for freefont-ttf. > ;; The "-src" pattern is for "TeXmacs-1.0.7.9-src.tar.gz". > ;; The "-gnu[0-9]" pattern is for "icecat-38.4.0-gnu1.tar.bz2". > (make-regexp "^([^.]+)-([0-9]|[^-])+(-(src|gnu[0-9]))?\\.(tar\\.|zip$)= ")) This comment remains valid because there are .zip files in ftp.gnu.org/gnu/freefont, so I think we should keep it. Thanks, it=E2=80=99s a nice to have these fonts built from source! Ludo=E2=80=99.