From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add wireshark
Date: Sat, 04 Jun 2016 23:55:32 +0200
Message-ID: <87a8j0wre3.fsf@gnu.org>
References: <87zir35p5d.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b9JXg-00087r-GL
	for guix-devel@gnu.org; Sat, 04 Jun 2016 17:55:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b9JXc-0002Uz-Au
	for guix-devel@gnu.org; Sat, 04 Jun 2016 17:55:39 -0400
In-Reply-To: <87zir35p5d.fsf@saiph.selenimh> (Nicolas Goaziou's message of
	"Thu, 02 Jun 2016 22:09:18 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Here is a new attempt to add a package: wireshark.
>
> I don't like the "python-wrapper" part because it implies a propagated
> python. OTOH, providing only "python" generates a lot of screaming
> during patch environment phase, but doesn't seem to alter the final
> executable.

Right, it=E2=80=99s not listed in =E2=80=98guix gc --references=E2=80=99, s=
o that=E2=80=99s fine.

> I'm not sure about the locations of plugins directory. Default is in the
> store, which means you cannot add more. I don't use this, so I don't
> know if there's a better place.

I guess we can revisit it later when someone needs a plugin.

> From e31d8434e26100bc95e2c7fa8a98dafcb4b49c45 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Thu, 2 Jun 2016 21:02:14 +0200
> Subject: [PATCH] gnu: Add wireshark.
>
> * gnu/packages/networking.scm (wireshark): New variable.

Applied with minor changes:

> +       `(,(string-append "--with-c-ares=3D" (assoc-ref %build-inputs "c-=
ares"))
> +         ,(string-append "--with-krb5=3D" (assoc-ref %build-inputs "krb5=
"))

I changed it to (list (string-append =E2=80=A6) =E2=80=A6), which I find mo=
re readable.

> +\"packet sniffer\", that lets you capture and interactively browse the
   ^

I changed it to @dfn{packet sniffer}.

Thank you!

Ludo=E2=80=99.