Re: [PATCH] Add wireshark

[ludo@gnu.org (Ludovic Courtès)]

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Here is a new attempt to add a package: wireshark.
>
> I don't like the "python-wrapper" part because it implies a propagated
> python. OTOH, providing only "python" generates a lot of screaming
> during patch environment phase, but doesn't seem to alter the final
> executable.

Right, it’s not listed in ‘guix gc --references’, so that’s fine.

> I'm not sure about the locations of plugins directory. Default is in the
> store, which means you cannot add more. I don't use this, so I don't
> know if there's a better place.

I guess we can revisit it later when someone needs a plugin.

> From e31d8434e26100bc95e2c7fa8a98dafcb4b49c45 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Thu, 2 Jun 2016 21:02:14 +0200
> Subject: [PATCH] gnu: Add wireshark.
>
> * gnu/packages/networking.scm (wireshark): New variable.

Applied with minor changes:

> +       `(,(string-append "--with-c-ares=" (assoc-ref %build-inputs "c-ares"))
> +         ,(string-append "--with-krb5=" (assoc-ref %build-inputs "krb5"))

I changed it to (list (string-append …) …), which I find more readable.

> +\"packet sniffer\", that lets you capture and interactively browse the
   ^

I changed it to @dfn{packet sniffer}.

Thank you!

Ludo’.