From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH v2] gnu: Add lrzip.
Date: Sat, 23 Jul 2016 12:45:07 +0200
Message-ID: <87a8h8ocp8.fsf@gnu.org>
References: <ab4cc6834c4b4d3f4909b06ab505643f@tobias.gr>
	<20160721202430.31332-1-me@tobias.gr>
	<a482e23e3702fc74d75cedf20d1f009c@tobias.gr> <87mvl9q0il.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40031)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQuR2-0005xa-4O
	for guix-devel@gnu.org; Sat, 23 Jul 2016 06:45:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQuR0-0002wG-Ss
	for guix-devel@gnu.org; Sat, 23 Jul 2016 06:45:32 -0400
In-Reply-To: <87mvl9q0il.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 22 Jul 2016 15:13:06 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org, Guix-devel <guix-devel-bounces+me=tobias.gr@gnu.org>

Hi Tobias,

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>
>> On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
>>> +    (native-inputs
>>> +     `(,@(if (string-prefix? "i686" (or (%current-target-system)
>>> +                                        (%current-system)))
>>> +             `(("nasm" ,nasm))
>>> +             '())
>>
>> Hmm. Not sure where this falls on the =E2=80=98let the code speak for it=
self=E2=80=99
>> to =E2=80=98should have added a comment=E2=80=99 scale.
>>
>> Guess I'll wait for another review + patch or a very friendly committer.
>
> I have another idea: could you create a Savannah account and tell me
> your user name?  :-)

I=E2=80=99ve added you to the Savannah group so you can commit directly.

Please see the =E2=80=98HACKING=E2=80=99 file on how to be a good citizen. =
 ;-)
In particular, make sure to configure commit signing as noted at
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22883#16>.

So I think the last iteration of this patch, with a comment regarding
the i686 case as you wrote above, will be a good thing to push.

Happy hacking!

Ludo=E2=80=99.