From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 01/13] gnu: kguiaddons: Fix regression caused by update to
	qt 5.7.
Date: Sun, 21 Aug 2016 15:44:41 -0400
Message-ID: <87a8g5ewk6.fsf@netris.org>
References: <20160820215957.GA6502@jasmine>
	<20160821140825.13048-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbYhD-0006ue-Tg
	for guix-devel@gnu.org; Sun, 21 Aug 2016 15:46:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbYh9-0002FT-Qn
	for guix-devel@gnu.org; Sun, 21 Aug 2016 15:46:14 -0400
Received: from world.peace.net ([50.252.239.5]:41566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbYh9-0002Eb-MX
	for guix-devel@gnu.org; Sun, 21 Aug 2016 15:46:11 -0400
In-Reply-To: <20160821140825.13048-1-david@craven.ch> (David Craven's message
	of "Sun, 21 Aug 2016 16:08:14 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> writes:

> * gnu/packages/kde-frameworks.scm (kguiaddons)[arguments]:
> Remove phase 'start-xorg-server. Add phase 'check-setup.
> ---
>  gnu/packages/kde-frameworks.scm | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index af81547..ba26952 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -539,12 +539,9 @@ infrastructure.")
>      (arguments
>       `(#:phases
>          (modify-phases %standard-phases
> -          (add-before 'check 'start-xorg-server
> -            (lambda* (#:key inputs #:allow-other-keys)
> -              ;; The test suite requires a running X server.
> -              (system (string-append (assoc-ref inputs "xorg-server")
> -                                     "/bin/Xvfb :1 &"))
> -              (setenv "DISPLAY" ":1")
> +          (add-before 'check 'check-setup
> +            (lambda* _
> +              (setenv "QT_QPA_PLATFORM" "offscreen")
>               #t)))))

The #t should line up with (setenv ...), i.e. it should be moved one
column to the right.  Otherwise, looks good to me!

     Thanks,
       Mark