From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 3/4] gnu: node: Do not use bundled dependencies. Date: Sat, 27 Aug 2016 23:38:13 +0300 Message-ID: <87a8fydk22.fsf@gmail.com> References: <20160827112333.1759-1-jlicht@fsfe.org> <20160827112333.1759-4-jlicht@fsfe.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdkMr-000498-Mp for guix-devel@gnu.org; Sat, 27 Aug 2016 16:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdkMo-0008MO-Fk for guix-devel@gnu.org; Sat, 27 Aug 2016 16:38:17 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:35223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdkMo-0008MK-8T for guix-devel@gnu.org; Sat, 27 Aug 2016 16:38:14 -0400 Received: by mail-lf0-x243.google.com with SMTP id l89so5321259lfi.2 for ; Sat, 27 Aug 2016 13:38:14 -0700 (PDT) In-Reply-To: <20160827112333.1759-4-jlicht@fsfe.org> (Jelle Licht's message of "Sat, 27 Aug 2016 13:23:32 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jelle Licht Cc: guix-devel@gnu.org Jelle Licht (2016-08-27 14:23 +0300) wrote: > The Node build system was previously building its own copies of > C-ares and http-parser. > > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > [arguments]: Add configure flags for using system libraries. > --- > gnu/packages/node.scm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > > diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm > index d1c5e1b..7c020e6 100644 > --- a/gnu/packages/node.scm > +++ b/gnu/packages/node.scm > @@ -25,6 +25,7 @@ > #:use-module (guix derivations) > #:use-module (guix download) > #:use-module (guix build-system gnu) > + #:use-module (gnu packages adns) > #:use-module (gnu packages base) > #:use-module (gnu packages compression) > #:use-module (gnu packages gcc) > @@ -86,6 +87,8 @@ it does not buffer data, it can be interrupted at anytime.") > '(#:configure-flags '("--shared-openssl" > "--shared-zlib" > "--shared-libuv" > + "--shared-cares" > + "--shared-http-parser" > "--without-snapshot") > #:phases > (modify-phases %standard-phases > @@ -158,7 +161,9 @@ it does not buffer data, it can be interrupted at anytime.") > (inputs > `(("libuv" ,libuv) > ("openssl" ,tls:openssl) > - ("zlib" ,zlib))) > + ("zlib" ,compression:zlib) This change shouldn't belong this patch: here you use 'compression' prefix which is introduced by the next patch. This would leave the git repo in a broken state on this commit. > + ("http-parser" ,http-parser) > + ("c-ares" ,c-ares))) > (synopsis "Evented I/O for V8 JavaScript") > (description "Node.js is a platform built on Chrome's JavaScript runtime > for easily building fast, scalable network applications. Node.js uses an -- Alex