From: ng0 <ng0@n0.is>
To: John Darrington <john@darrington.wattle.id.au>,
Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: Addition to gnu-build-system: make test.
Date: Sun, 28 Aug 2016 10:46:19 +0000 [thread overview]
Message-ID: <87a8fxkw78.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <20160828094103.GA25813@jocasta.intra>
Can we ease it up in a different way for applications which do not have
aliases?
Maybe using something like
#:check-is-tests? #t in the arguments, which fails when check and test
exist?
John Darrington <john@darrington.wattle.id.au> writes:
> [ Unknown signature status ]
> "make check" is what the Gnu Coding Standards specify:
> http://www.gnu.org/prep/standards/standards.html#Standard-Targets
>
> So I think it should stay as it is - at least for the gnu-build-system
>
> J'
>
> On Sun, Aug 28, 2016 at 12:05:47PM +0300, Efraim Flashner wrote:
> On Fri, Aug 26, 2016 at 04:14:25PM +0000, ng0 wrote:
> >
> > 2016-08-26 15:16 <ng0> recently when I pointed out to someone and they
> > added a make check which just calls the original make test, I was
> > wondering if our gnu build system should try for make test and make
> > check.. this seems to be very common test instead of check
> > 2016-08-26 15:19 <kyamashita> ng0: Or maybe try one if the other fails?
> > 2016-08-26 15:19 <ng0> yes.. very often I had to replace check with just
> > test
> > 2016-08-26 15:21 <kyamashita> It might be worth bringing up on the
> > guix-devel mailing list to see what others think.
> > 2016-08-26 15:21 <ng0> yes.. I will do so later
> >
> > What do others think? How can we extend gnu-build-system so that make
> > test can be used but make check is not ignored?
> > --
> > ng0
> > For non-prism friendly talk find me on http://www.psyced.org
> >
>
> I was curious how many times we use test-target:
>
> $ grep test-target gnu/packages/*scm | wc -l
> 87
> $ grep test-target gnu/packages/*scm | grep \"test\" | wc -l
> 52
> $ grep test-target gnu/packages/*scm | grep \"tests\" | wc -l
> 8
>
> I guess the real question is, will running an extra `make test' after
> `make check' break anything? Also, I'm sure some of the makefiles have
> one as an alias of the other, we don't want to run the tests twice.
>
>
> --
> Efraim Flashner <efraim@flashner.co.il> ?????????? ??????????
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
>
>
>
> --
> Avoid eavesdropping. Send strong encryted email.
> PGP Public key ID: 1024D/2DE827B3
> fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
> See http://sks-keyservers.net or any PGP keyserver for public key.
>
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-08-28 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 16:14 Addition to gnu-build-system: make test ng0
2016-08-28 9:05 ` Efraim Flashner
2016-08-28 9:41 ` John Darrington
2016-08-28 10:46 ` ng0 [this message]
2016-08-28 12:23 ` John Darrington
2016-08-28 12:37 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8fxkw78.fsf@we.make.ritual.n0.is \
--to=ng0@n0.is \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.