From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: Cosmetical change: remove inconsistent "$file ends here"? Date: Sun, 25 Sep 2016 11:30:41 +0300 Message-ID: <87a8ewl6tq.fsf@gmail.com> References: <871t09t6f1.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo4qk-0006wL-3M for guix-devel@gnu.org; Sun, 25 Sep 2016 04:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bo4qe-0005T7-5N for guix-devel@gnu.org; Sun, 25 Sep 2016 04:31:49 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo4qd-0005Sz-TN for guix-devel@gnu.org; Sun, 25 Sep 2016 04:31:44 -0400 Received: by mail-lf0-f68.google.com with SMTP id l131so7893894lfl.0 for ; Sun, 25 Sep 2016 01:31:43 -0700 (PDT) In-Reply-To: <871t09t6f1.fsf@we.make.ritual.n0.is> (ng0's message of "Sat, 24 Sep 2016 20:00:02 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2016-09-24 20:00 +0000) wrote: > We should either be consistent with this in all files or remove this > altogether in my opinion. > >> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >> gnu/build/vm.scm:323:;;; vm.scm ends here ... > What do you think? I don't know what the original purpose of this convention is, it was probably invented in those ancient times when dinosaurs walked by streets, but I kinda like these "ends here" things :-) The only purpose I see in using them: you can be sure that there will not appear redundant newlines (introduced by untidy commits) in the end of files. Anyway, I vote for leaving them and adding the missing ones. -- Alex