Leo Famulari <leo@famulari.name> writes:

> On Fri, Oct 21, 2016 at 04:47:14PM -0400, Kei Kebreau wrote:
>> This is a patch I think we need before fixing up freeimage. Thoughts?
>
> Thanks for working on this!
>
>> + (uri (string-append "mirror://debian/pool/main/j/jxrlib/jxrlib_"
>> +                                  version ".orig.tar.gz"))
>
> Why not download it from the upstream site? We prefer to do that when
> possible.
>
> https://jxrlib.codeplex.com/releases/view/107208
>

The URL for the upstream site's tarball is
http://download-codeplex.sec.s-msft.com/Download/Release?ProjectName=jxrlib&DownloadId=685250&FileTime=130142428056630000&Build=21031.

Is something like that acceptable in Guix code? I know it works with
wget, but I was hesitant to use it as the source URL.


>> +    (license
>> +     (license:non-copyleft
>> +      "file://Makefile"
>> +      "See the header of the Makefile in the distribution."))
>
> That looks like a 2 clause BSD license:
> https://opensource.org/licenses/BSD-2-Clause
>
Indeed it does. I'll have it changed in the next patch I submit.

>> diff --git a/gnu/packages/patches/libjxr-fix-typos.patch
>> b/gnu/packages/patches/libjxr-fix-typos.patch
>> new file mode 100644
>> index 0000000..3c051dd
>> --- /dev/null
>> +++ b/gnu/packages/patches/libjxr-fix-typos.patch
>> @@ -0,0 +1,60 @@
>> +Description: Fix typos and remove some warnings
>> +Author: Mathieu Malaterre <malat@debian.org>
>
> Can you include a link to the source of this patch?
>

This patch comes from Debian's set of patches for the sources. Could I
leave "This patch comes from Debian" with the link to it on the top, or
is more detail necessary?

>> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch
>> b/gnu/packages/patches/libjxr-use-cmake.patch
>> new file mode 100644
>> index 0000000..cb5919e
>> --- /dev/null
>> +++ b/gnu/packages/patches/libjxr-use-cmake.patch
>> @@ -0,0 +1,143 @@
>> +Description: Prefer a cmake based build system
>> +Author: Mathieu Malaterre <malat@debian.org>
>> +Forwarded: https://jxrlib.codeplex.com/discussions/440294
>
> Why doesn't upstream's build system work?

Upstream's build system simply doesn't have configuration or
installation targets in the provided Makefile. Using the cmake patch
makes the definition cleaner at the cost of relying on outside work
[1]. If this is not acceptable, I can see about writing manual
replacement phases to the best of my ability.

[1]: https://jxrlib.codeplex.com/discussions/440294