From: Marius Bakke <mbakke@fastmail.com>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>, guix-devel@gnu.org
Subject: Re: [PATCH] mps-youtube, revision 3
Date: Sat, 05 Nov 2016 12:33:13 +0000 [thread overview]
Message-ID: <87a8de6r92.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <081db68d-fd77-b857-ba1a-70600469ffd1@crazy-compilers.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Am 04.11.2016 um 20:23 schrieb ng0:
>> [PATCH 1/2] gnu: Add python-pafy.
>>
>> - made youtube-dl propagated-input as suggested by harmut
>>
>> [PATCH 2/2] gnu: Add mps-youtube.
>>
>> - no changes
>>
>
> Both LGTM.
>
> Adding the comment about youtube_dl was a good idea :-)
Both of these packages have 'or later' in the source license header.
Also mps-youtube does not need mpv or ffmpeg in inputs, since they are
optional runtime dependencies. Additionally home-page should be https.
Other than that this works great, neat program!
I pushed the patches with these changes, and a minor edit to the
mps-youtube description to make it clear that mplayer or mpv is
required.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
next prev parent reply other threads:[~2016-11-05 12:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:40 [PATCH] mps-youtube ng0
2016-11-02 10:40 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-02 17:27 ` Hartmut Goebel
2016-11-04 18:18 ` ng0
2016-11-04 18:41 ` Hartmut Goebel
2016-11-04 18:52 ` ng0
2016-11-04 19:23 ` [PATCH] mps-youtube, revision 3 ng0
2016-11-04 19:23 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-04 19:23 ` [PATCH 2/2] gnu: Add mps-youtube ng0
2016-11-04 19:42 ` [PATCH] mps-youtube, revision 3 Hartmut Goebel
2016-11-05 12:33 ` Marius Bakke [this message]
2016-11-05 12:49 ` ng0
2016-11-02 10:40 ` [PATCH 2/2] gnu: Add mps-youtube ng0
2016-11-02 12:34 ` [PATCH] mps-youtube Marius Bakke
2016-11-02 13:53 ` ng0
2016-11-02 14:20 ` Marius Bakke
2016-11-02 14:24 ` [PATCH] mps-youtube, revision 2 ng0
2016-11-02 14:24 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-02 14:24 ` [PATCH 2/2] gnu: Add mps-youtube ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8de6r92.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.