From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add LLVM variant with RTTI support.
Date: Tue, 08 Nov 2016 21:02:00 +0100 [thread overview]
Message-ID: <87a8d991vr.fsf@elephly.net> (raw)
In-Reply-To: <20161108160449.GB19400@jasmine>
Leo Famulari <leo@famulari.name> writes:
> On Tue, Nov 08, 2016 at 09:10:46AM +0100, Ricardo Wurmus wrote:
>>
>> Leo Famulari <leo@famulari.name> writes:
>>
>> > On Sun, Nov 06, 2016 at 08:34:23PM +0100, Ricardo Wurmus wrote:
>> >> * gnu/packages/llvm.scm (llvm-with-rtti): New variable.
>> >
>> > Seems okay, although would it make sense to enable this in the main LLVM
>> > package?
>>
>> I’m not sure, because it seems to require dependent packages to also
>> support this or else be built with “-fno-rtti”. We should build this
>> out in a separate branch and see how much damage this causes and how
>> many changes to existing packages this requires.
>
> Perhaps, but let's not let it delay this patch :)
Okay :) Pushed as 8ae60404510fedb89502e27c0e73f830ab429641.
Thanks for the review!
~~ Ricardo
prev parent reply other threads:[~2016-11-08 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 19:34 [PATCH 1/2] gnu: Add LLVM variant with RTTI support Ricardo Wurmus
2016-11-06 19:34 ` [PATCH 2/2] gnu: Add faust-2 Ricardo Wurmus
2016-11-07 23:10 ` Leo Famulari
2016-11-07 23:10 ` [PATCH 1/2] gnu: Add LLVM variant with RTTI support Leo Famulari
2016-11-08 5:40 ` Eric Bavier
2016-11-08 8:10 ` Ricardo Wurmus
2016-11-08 16:04 ` Leo Famulari
2016-11-08 20:02 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8d991vr.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.