From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2.
Date: Thu, 10 Nov 2016 13:35:18 +0100
Message-ID: <87a8d7tsvt.fsf@gnu.org>
References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>
	<1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com>
	<87vavvtxxb.fsf@gnu.org> <582452C4.9000700@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36496)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4oZi-00059T-4P
	for guix-devel@gnu.org; Thu, 10 Nov 2016 07:35:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4oZf-0008Vy-2A
	for guix-devel@gnu.org; Thu, 10 Nov 2016 07:35:26 -0500
In-Reply-To: <582452C4.9000700@crazy-compilers.com> (Hartmut Goebel's message
	of "Thu, 10 Nov 2016 11:58:12 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 10.11.2016 um 11:46 schrieb Ludovic Court=C3=A8s:
>>> > +    (arguments
>>> > +     `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes)
>> So probably we should only build the Python 2 variant?  WDYT?
>>
>
> The main feature of PyPDF2 is that is supports Python 3, what the old
> pyPdf does not. So we need Python 3.
>
> The test suite does not fail in the sense that it shows bugs, but in a
> way that shows the test suite was not adopted to work with Python 3. The
> test-suite is negligible anyway.  I'll update the comment.

Hmm, OK.  That doesn=E2=80=99t make it sounds like it=E2=80=99s really safe=
 to use with
Python=C2=A03.

At the very least, the test suite should be disabled only for the
Python=C2=A03 variant IMO, and with a slightly more detailed explanation in
the comment.

Thanks!

Ludo=E2=80=99.