From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant.
Date: Tue, 06 Dec 2016 10:10:57 +0100
Message-ID: <87a8c9xw0u.fsf@gnu.org>
References: <20161203194113.6456663e@scratchpost.org>
	<20161204040037.21758-1-ajpatter@uwaterloo.ca>
	<20161204040037.21758-2-ajpatter@uwaterloo.ca>
	<871sxm14rf.fsf@gnu.org> <20161205173827.49a9001a@uwaterloo.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cEBnC-0007Zf-I0
	for bug-guix@gnu.org; Tue, 06 Dec 2016 04:12:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cEBn8-0006WG-EZ
	for bug-guix@gnu.org; Tue, 06 Dec 2016 04:12:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42224)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cEBn8-0006W8-Ad
	for bug-guix@gnu.org; Tue, 06 Dec 2016 04:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cEBn8-0004MI-0B
	for bug-guix@gnu.org; Tue, 06 Dec 2016 04:12:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25101.B25101.148101547016694@debbugs.gnu.org>
In-Reply-To: <20161205173827.49a9001a@uwaterloo.ca> (Andy Patterson's message
	of "Mon, 5 Dec 2016 17:38:27 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 25101@debbugs.gnu.org

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> On Mon, 05 Dec 2016 21:48:36 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> > +(define-public sane-backends+hpaio=20=20
>>=20
>> Could you add a comment and a synopsis explaining what=E2=80=99s this is?
>>=20
>
> Sure, is the following patch ok?

Yup!

>> > +  (package
>> > +    (inherit sane-backends)
>> > +    (name "sane-backends+hpaio")
>> > +    (inputs
>> > +     `(("hplip" ,(@ (gnu packages cups) hplip))
>> > +       ,@(package-inputs sane-backends)))=20=20
>>=20
>> The closure size of this is 290 MiB whereas it=E2=80=99s 87 MiB for
>> =E2=80=98sane-backends=E2=80=99.  I suppose that=E2=80=99s the reason to=
 keep=E2=80=99em separated?
>>
>
> Yeah, and there's also the fact that hplip depends on sane-backends.
> But this is the reason I didn't change sane-backends into a private
> variable, and then make this the new sane-backends.

Oh right.

One last thing: should we renaming =E2=80=9Csane-backends=E2=80=9D to
=E2=80=9Csane-backends-minimal=E2=80=9D, and =E2=80=9Csane-backends+hpaio=
=E2=80=9D to =E2=80=9Csane-backends=E2=80=9D?

That way all scanners would work out of the box, at the expense of extra
disk usage, but that is roughly what patch 2/2 does anyway.

Thanks!

Ludo=E2=80=99.