From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: Cuirass and duplicate derivations Date: Mon, 09 Jan 2017 01:41:42 +0100 Message-ID: <87a8b1xdx5.fsf@gnu.org> References: <87r35o8x0h.fsf@gnu.org> <87shq35tue.fsf@gnu.org> <87y3zv4c4i.fsf@gnu.org> <87fuljj5ku.fsf@gnu.org> <87tw9mzq4v.fsf@gnu.org> <87eg0l9m38.fsf_-_@gnu.org> <87tw99yw8l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQO22-00020B-On for guix-devel@gnu.org; Sun, 08 Jan 2017 19:41:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQO21-0000Zz-Ly for guix-devel@gnu.org; Sun, 08 Jan 2017 19:41:50 -0500 In-Reply-To: <87tw99yw8l.fsf@gnu.org> (Mathieu Lirzin's message of "Mon, 09 Jan 2017 00:20:42 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mathieu Lirzin writes: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> What change would you suggest to solve this problem? It would be best >> if Cuirass allowed several jobs building the same derivations (the key >> could be an autoincrement counter instead of the (drv,eval) pair maybe?) > > Seems reasonable to me. I will do that. > Thanks. After a second thought, I think maybe it is sufficient to just ignore when a derivation is added twice by an evaluation. As a consequence 'cuirass' will only try to realize the derivation once per evaluation. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-database-db-add-derivation-Don-t-try-to-add-a-deriva.patch >From 568d0e1b0866a45e95440d17b6e8f1740cc23e3f Mon Sep 17 00:00:00 2001 From: Mathieu Lirzin Date: Mon, 9 Jan 2017 01:29:48 +0100 Subject: [PATCH] database: db-add-derivation: Don't try to add a derivation twice. * src/cuirass/database.scm (db-add-derivation): Ignore if JOB is already present in DB. --- src/cuirass/database.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm index 870cdc0..702e643 100644 --- a/src/cuirass/database.scm +++ b/src/cuirass/database.scm @@ -147,7 +147,7 @@ INSERT OR IGNORE INTO Specifications (repo_name, url, load_path, file, \ (define (db-add-derivation db job) "Store a derivation result in database DB and return its ID." (sqlite-exec db "\ -INSERT INTO Derivations (derivation, job_name, evaluation)\ +INSERT OR IGNORE INTO Derivations (derivation, job_name, evaluation)\ VALUES ('~A', '~A', '~A');" (assq-ref job #:derivation) (assq-ref job #:job-name) -- 2.11.0 --=-=-= Content-Type: text/plain WDYT? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 --=-=-=--