From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/1] gnu: Add scrypt. Date: Mon, 16 Jan 2017 14:39:49 +0100 Message-ID: <87a8aryvh6.fsf@gnu.org> References: <20170116063633.GA17734@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cT7Vv-00008W-ID for guix-devel@gnu.org; Mon, 16 Jan 2017 08:40:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cT7Vq-0003om-H9 for guix-devel@gnu.org; Mon, 16 Jan 2017 08:39:59 -0500 In-Reply-To: <20170116063633.GA17734@jasmine> (Leo Famulari's message of "Mon, 16 Jan 2017 01:36:33 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Mon, Jan 16, 2017 at 12:43:14AM -0500, Leo Famulari wrote: >> * gnu/packages/crypto.scm (scrypt): New variable. > >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + (add-after 'unpack 'patch-command-invocations > > I realized this indentation is too far to the right. > >> + (synopsis "Memory-hard key derivation function") > > And the synopsis should probably be something like "Memory-hard > encryption tool". At least, it should include "encryption tool". Agreed. Also: > + (add-after 'unpack 'patch-command-invocations > + (lambda _ > + (substitute* '("Makefile.in" "autocrap/Makefile.am") > + (("command -p") "")) > + #t)) It=E2=80=99s probably enough to patch Makefile.in, and it avoids triggering= an =E2=80=98automake=E2=80=99 invocation due to Makefile.am being more recent. The rest LGTM, thanks! Ludo=E2=80=99.