From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: Add scrypt.
Date: Mon, 16 Jan 2017 14:39:49 +0100 [thread overview]
Message-ID: <87a8aryvh6.fsf@gnu.org> (raw)
In-Reply-To: <20170116063633.GA17734@jasmine> (Leo Famulari's message of "Mon, 16 Jan 2017 01:36:33 -0500")
Leo Famulari <leo@famulari.name> skribis:
> On Mon, Jan 16, 2017 at 12:43:14AM -0500, Leo Famulari wrote:
>> * gnu/packages/crypto.scm (scrypt): New variable.
>
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-command-invocations
>
> I realized this indentation is too far to the right.
>
>> + (synopsis "Memory-hard key derivation function")
>
> And the synopsis should probably be something like "Memory-hard
> encryption tool". At least, it should include "encryption tool".
Agreed.
Also:
> + (add-after 'unpack 'patch-command-invocations
> + (lambda _
> + (substitute* '("Makefile.in" "autocrap/Makefile.am")
> + (("command -p") ""))
> + #t))
It’s probably enough to patch Makefile.in, and it avoids triggering an
‘automake’ invocation due to Makefile.am being more recent.
The rest LGTM, thanks!
Ludo’.
prev parent reply other threads:[~2017-01-16 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 5:43 [PATCH 1/1] gnu: Add scrypt Leo Famulari
2017-01-16 6:36 ` Leo Famulari
2017-01-16 13:39 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8aryvh6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.