From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] tests: Add 'prosody-service-type' test.
Date: Fri, 10 Feb 2017 23:24:44 +0100
Message-ID: <87a89t65w3.fsf@gnu.org>
References: <20170205185854.4345-1-clement@lassieur.org>
	<20170205185854.4345-3-clement@lassieur.org> <87d1espwno.fsf@gnu.org>
	<87r335ucif.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ccJcY-0006Sn-Ig
	for guix-devel@gnu.org; Fri, 10 Feb 2017 17:24:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ccJcV-0004UE-AU
	for guix-devel@gnu.org; Fri, 10 Feb 2017 17:24:50 -0500
In-Reply-To: <87r335ucif.fsf@lassieur.org> (=?utf-8?Q?=22Cl=C3=A9ment?=
	Lassieur"'s message of "Fri, 10 Feb 2017 19:27:52 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: guix-devel@gnu.org

Hello Cl=C3=A9ment,

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:

[...]

>>> +(define (run-xmpp-test name xmpp-service pid-file create-account)
>>> +  "Run a test of an OS running XMPP-SERVICE, which writes its PID to P=
ID-FILE."
>>> +  (mlet* %store-monad ((os -> (marionette-operating-system
>>> +                               (os-with-service xmpp-service)
>>> +                               #:imported-modules '((gnu services herd=
))))
>>
>> I think you can remove =E2=80=98os-with-service=E2=80=99 and simply add =
the Prosody
>> service explicitly in =E2=80=98%base-os=E2=80=99 (which could be rename =
=E2=80=98%prosody-os=E2=80=99
>> maybe).
>
> But then, my test wouldn't be generic anymore, would it?  I would like
> it to be Prosody-independent, so that one can add, say, the ejabberd
> service easily.  That's why I call the service 'xmpp-daemon' instead of
> 'prosody'.  WDYT?

I think you=E2=80=99re right.  :-)  I didn=E2=80=99t know you had this in m=
ind, but it=E2=80=99s
a good idea.

Ludo=E2=80=99.