From: ludo@gnu.org (Ludovic Courtès)
To: "Clément Lassieur" <clement@lassieur.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] tests: Add 'prosody-service-type' test.
Date: Fri, 10 Feb 2017 23:24:44 +0100 [thread overview]
Message-ID: <87a89t65w3.fsf@gnu.org> (raw)
In-Reply-To: <87r335ucif.fsf@lassieur.org> ("Clément Lassieur"'s message of "Fri, 10 Feb 2017 19:27:52 +0100")
Hello Clément,
Clément Lassieur <clement@lassieur.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
[...]
>>> +(define (run-xmpp-test name xmpp-service pid-file create-account)
>>> + "Run a test of an OS running XMPP-SERVICE, which writes its PID to PID-FILE."
>>> + (mlet* %store-monad ((os -> (marionette-operating-system
>>> + (os-with-service xmpp-service)
>>> + #:imported-modules '((gnu services herd))))
>>
>> I think you can remove ‘os-with-service’ and simply add the Prosody
>> service explicitly in ‘%base-os’ (which could be rename ‘%prosody-os’
>> maybe).
>
> But then, my test wouldn't be generic anymore, would it? I would like
> it to be Prosody-independent, so that one can add, say, the ejabberd
> service easily. That's why I call the service 'xmpp-daemon' instead of
> 'prosody'. WDYT?
I think you’re right. :-) I didn’t know you had this in mind, but it’s
a good idea.
Ludo’.
prev parent reply other threads:[~2017-02-10 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 18:58 [PATCH 0/2] Add a test for the Prosody service Clément Lassieur
2017-02-05 18:58 ` [PATCH 1/2] service: shepherd: Replace spaces with hyphens in file names Clément Lassieur
2017-02-08 14:40 ` Ludovic Courtès
2017-02-05 18:58 ` [PATCH 2/2] tests: Add 'prosody-service-type' test Clément Lassieur
2017-02-06 9:48 ` Clément Lassieur
2017-02-08 14:47 ` Ludovic Courtès
2017-02-10 18:17 ` [PATCH] " Clément Lassieur
2017-02-10 22:42 ` Ludovic Courtès
2017-02-10 18:27 ` [PATCH 2/2] " Clément Lassieur
2017-02-10 22:24 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a89t65w3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=clement@lassieur.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.