bug#26438: [PATCH] Add fabric, python-paramiko: Update to 1.17.4.

bug#26438: [PATCH] Add fabric, python-paramiko: Update to 1.17.4.

[Ben Sturmfels]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Hi Folks,

Here's my first attempt at a Guix package - a tool called Fabric which
is used for for web app deployment.

Couple of notes:

1. I found that I needed to upgrade python-paramiko to minimum 1.17.4 to
avoid an incompatibility between python-paramiko and newer
python-pycrypto. I'm not sure what the implications are of this.
Technically only the Python 2 version needs to be upgraded, since Fabric
is Python 2 only, but I've upgraded both for consistency.

2. I've disabled tests for now as they fail when the package attempts to
download the "test-require" dependency "fudge". What's the normal way to
stop the Python package doing it's own dependency downloading? Happy to
also package "python2-fudge", but that didn't fix the downloading issue.

Cheers,
Ben

--
Ben Sturmfels

Sturm - Software Engineering
www.sturm.com.au
(03) 9024 2467

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-fabric-python-paramiko-Update-to-1.17.4.patch --]
[-- Type: text/x-patch, Size: 3035 bytes --]

From 521b29606ca4e1a34c9db89fbc22201eea581370 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben@sturm.com.au>
Date: Tue, 11 Apr 2017 00:06:20 +1000
Subject: [PATCH] gnu: Add fabric, python-paramiko: Update to 1.17.4.

* gnu/packages/python.scm (python-paramiko): Update to 1.17.4.
* gnu/packages/admin.scm (fabric): New variable.
---
 gnu/packages/admin.scm  | 34 ++++++++++++++++++++++++++++++++++
 gnu/packages/python.scm |  4 ++--
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index f19bf5a48..d4eaabadd 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2048,3 +2048,37 @@ environments to get useful results.  Therefore, Intel GPU Tools includes
 low-level tools and tests specifically for development and testing of the
 Intel DRM Driver.")
     (license license:expat)))
+
+(define-public fabric
+  (package
+    (name "fabric")
+    (version "1.13.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Fabric" version))
+       (sha256
+        (base32
+         "1z17hw0yiqp1blq217zxkg2jzkv8qd79saqhscgsw14mwlcqpwd0"))))
+    (build-system python-build-system)
+    (arguments
+    `(#:tests? #f ; Tests attempt to download Python "fudge" package.
+      #:python ,python-2)) ; Python 2 only.
+    (propagated-inputs
+     ;; Required upgrading python-paramiko 1.17.4 to fix an incompatibility
+     ;; between python-paramiko and newer python-pycrypto. Without this, the
+     ;; `fab` command fails with "ValueError: CTR mode needs counter
+     ;; parameter, not IV". See:
+     ;; https://github.com/paramiko/paramiko/pull/714#issuecomment-281191548.
+     `(("python2-paramiko" ,python2-paramiko)))
+    (home-page "http://fabfile.org")
+    (synopsis "Simple Pythonic remote execution and deployment tool")
+    (description
+     "Fabric is designed to upload files and run shell commands on a number of
+servers in parallel or serially.  These commands are grouped in tasks (which
+are regular Python functions) and specified in a \"fabfile\".
+
+It is similar to Capistrano, except it's implemented in Python and doesn't
+expect you to be deploying Rails applications.  Fabric is a simple, Pythonic
+tool for remote execution and deployment.")
+    (license license:bsd-2)))
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0746af24a..231c62929 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -529,14 +529,14 @@ John the Ripper).")
 (define-public python-paramiko
   (package
     (name "python-paramiko")
-    (version "1.16.0")
+    (version "1.17.4")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "paramiko" version))
        (sha256
         (base32
-         "14k8z7ndc3zk5xivnm4d8lncchx475ll5izpf8vmfbq7rp9yp5rj"))))
+         "1rs2qcmskcmq66q6g5al08wa41l9am0fad5r719m8wf91msyylqw"))))
     (build-system python-build-system)
     (arguments
      '(;; FIXME: One test fails with "EOFError not raised by connect".
-- 
2.12.2

bug#26438: [PATCH] Add fabric, python-paramiko: Update to 1.17.4.

[Ludovic Courtès]

Hello,

Ben Sturmfels <ben@sturm.com.au> skribis:

> Couple of notes:
>
> 1. I found that I needed to upgrade python-paramiko to minimum 1.17.4 to
> avoid an incompatibility between python-paramiko and newer
> python-pycrypto. I'm not sure what the implications are of this.
> Technically only the Python 2 version needs to be upgraded, since Fabric
> is Python 2 only, but I've upgraded both for consistency.

Sounds good.

> 2. I've disabled tests for now as they fail when the package attempts to
> download the "test-require" dependency "fudge". What's the normal way to
> stop the Python package doing it's own dependency downloading? Happy to
> also package "python2-fudge", but that didn't fix the downloading issue.

I would expect that adding python2-fudge would indeed fix the problem
(the setuptools machinery checks for already-available packages and only
tries to download as a last resort.)  Would need more investigation I
guess!

>>From 521b29606ca4e1a34c9db89fbc22201eea581370 Mon Sep 17 00:00:00 2001
> From: Ben Sturmfels <ben@sturm.com.au>
> Date: Tue, 11 Apr 2017 00:06:20 +1000
> Subject: [PATCH] gnu: Add fabric, python-paramiko: Update to 1.17.4.
>
> * gnu/packages/python.scm (python-paramiko): Update to 1.17.4.
> * gnu/packages/admin.scm (fabric): New variable.

I’ve split it into two commits and applied.

Thank you, and welcome!

Ludo’.