From: ludo@gnu.org (Ludovic Courtès)
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: 26805@debbugs.gnu.org
Subject: bug#26805: [PATCH] gs-fonts: add missing podule imports
Date: Sun, 14 May 2017 22:02:21 +0200 [thread overview]
Message-ID: <87a86ftdf6.fsf@gnu.org> (raw)
In-Reply-To: <20170514173128.28e799a1@sf> (Sergei Trofimovich's message of "Sun, 14 May 2017 17:31:28 +0100")
Hi,
Sergei Trofimovich <slyfox@inbox.ru> skribis:
> On Thu, 11 May 2017 22:49:05 +0200
[...]
>> >> (Alternately, we could rename SRFI-1’s ‘delete’ in (guix build utils),
>> >> so we’d still be matching a literal, but we’d have problems in places
>> >> that use both (guix build utils) and (srfi srfi-1).)
[...]
> Can you explain what is the problem of renaming ‘delete’ from srfi-1 in
> (guix build utils) module? How would hypothetical breakage happen?
> Is it because 'delete' from srfi-1 and renamed binding srfi-1 are not
> treated as the same binding by syntax rule?
The only problem would be in packages that use both (guix build utils)
and (srfi srfi-1), *and* do (modify-phase … (delete …)). Those packages
would have a syntax error due to ‘delete’ being shadowed by SRFI-1’s
‘delete’.
It’s easy to fix them, for example by using the #:prefix option when
importing (srfi srfi-1)… but it’s also easy to miss some of the
problems.
There’s yet another option, which is to:
(define-modules (guix build utils)
…
#:use-module (srfi srfi-1)
#:re-export (delete))
I think that one had none of the previously-discussed drawbacks.
Thoughts? Would you like to give it a try?
Ludo’.
next prev parent reply other threads:[~2017-05-14 20:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 15:40 bug#26805: [PATCH] gs-fonts: add missing podule imports Sergei Trofimovich
2017-05-07 19:06 ` bug#26805: [PATCH] gs-fonts: add missing module imports Danny Milosavljevic
2017-05-09 10:20 ` bug#26805: [PATCH] gs-fonts: add missing podule imports Ludovic Courtès
2017-05-09 20:36 ` Sergei Trofimovich
2017-05-10 11:53 ` Ludovic Courtès
2017-05-10 20:41 ` Sergei Trofimovich
2017-05-11 20:49 ` Ludovic Courtès
2017-05-14 16:31 ` Sergei Trofimovich
2017-05-14 20:02 ` Ludovic Courtès [this message]
2017-05-14 23:15 ` Sergei Trofimovich
2017-05-26 13:02 ` bug#26805: Re-exporting ‘delete’ from (guix build utils) Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a86ftdf6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26805@debbugs.gnu.org \
--cc=slyfox@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.