From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPXo0-00062o-Qx for guix-patches@gnu.org; Mon, 26 Jun 2017 13:28:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPXnv-0000wH-1X for guix-patches@gnu.org; Mon, 26 Jun 2017 13:28:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPXnu-0000v3-Tn for guix-patches@gnu.org; Mon, 26 Jun 2017 13:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dPXnu-0003hp-Dv for guix-patches@gnu.org; Mon, 26 Jun 2017 13:28:02 -0400 Subject: [bug#27355] [PATCH 3/7] gnu: Add libsigrokdecode. Resent-Message-ID: References: <20170614095813.1926-1-theodoros.for@openmailbox.org> <20170614095813.1926-3-theodoros.for@openmailbox.org> <20170619222054.028af180@scratchpost.org> <5950DD76.7030402@crazy-compilers.com> From: Theodoros Foradis Message-ID: <87a84ur8vs.fsf@openmailbox.org> In-reply-to: <5950DD76.7030402@crazy-compilers.com> Date: Mon, 26 Jun 2017 19:50:56 +0300 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 27355@debbugs.gnu.org Hello, > Hi, >> Also, reading srd.c it seems that this library embeds Python. Is it still supposed to be a propagated-input then? It doesn't need the executable at runtime or anything. Users probably do need the Python standard library, so I guess it's OK... Hartmut, what do you think? > > Sorry for answering late. > > I'm confident that python should be a *normal* input – although it > should be tested (and the result documented in guix.texi). I'm short in > time, so I can't test myself now. > > From the Documentation [1] I can not tell exactly how libpython behaves > if used embedded. But the code [2] says: > > Step 3 [… search python3 on $PATH] > > Step 4. Search the directories pointed to by the preprocessor variables > PREFIX and EXEC_PREFIX. These are supplied by the Makefile but can be > passed in as options to the configure script. > > So the PREFIX guix is setting is honoured (as a last resort). > > BTW: I assume glib should be a normal input, too. > > [1] https://docs.python.org/3/c-api/init.html > [2] https://github.com/python/cpython/blob/master/Modules/getpath.c#L73 > > [3] https://github.com/python/cpython/blob/master/Modules/getpath.c#L495 > [4] https://github.com/python/cpython/blob/master/Modules/getpath.c#L364 I have tested having either python/glibc as *normal* inputs. Cmake, which is used by pulseview, gives out an error and the build fails at the configure phase. Maybe I'm missing something? Regards, -- Theodoros Foradis