From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkHhO-0001Vl-Vv for guix-patches@gnu.org; Tue, 22 Aug 2017 18:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkHhO-0002eF-4z for guix-patches@gnu.org; Tue, 22 Aug 2017 18:31:02 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkHhO-0002eA-1N for guix-patches@gnu.org; Tue, 22 Aug 2017 18:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dkHhN-0002K0-OI for guix-patches@gnu.org; Tue, 22 Aug 2017 18:31:01 -0400 Subject: [bug#27977] [PATCH 1/2] services: herd: Fix matching ok responses from shepherd service. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170805222646.149cb45a@cbaines.net> <20170805213034.1012-1-mail@cbaines.net> <87h8wz38hf.fsf@gnu.org> <20170822174452.3784d96c@cbaines.net> Date: Wed, 23 Aug 2017 00:30:21 +0200 In-Reply-To: <20170822174452.3784d96c@cbaines.net> (Christopher Baines's message of "Tue, 22 Aug 2017 17:44:52 +0100") Message-ID: <87a82rnsle.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 27977-done@debbugs.gnu.org Christopher Baines skribis: > On Tue, 22 Aug 2017 17:52:44 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Probably this patch is better than reverting. >>=20 >> Thoughts? > > I had to apply that patch with --ignore-whitespace-change, as the code > in the middle of (current-services) has been indented outside of that > patch. Right, sorry about that (I have -bB in =E2=80=98vc-diff-switches=E2=80=99). > I think I get what is going on. As far as I understand it, the (match > results ((services _ ...) ... bit is equivilent to the use of first in > the other procedures, which suggests to me that you could use first in > (current-services)? I'm guessing that the only difference is that they > will fail differently on the empty list? Yes. I=E2=80=99ve pushed it as 7d14082d56462f7bef4254d65a21fd265fbce471. Thanks, Ludo=E2=80=99.