From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlHL4-0002j7-6v for guix-patches@gnu.org; Fri, 25 Aug 2017 12:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlHL1-0001kO-3F for guix-patches@gnu.org; Fri, 25 Aug 2017 12:20:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlHL0-0001kA-VN for guix-patches@gnu.org; Fri, 25 Aug 2017 12:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlHL0-00073y-Lt for guix-patches@gnu.org; Fri, 25 Aug 2017 12:20:02 -0400 Subject: [bug#27907] [PATCH] graph: Provide access to the package record in the emit Resent-Message-ID: References: <87lgn3w0n6.fsf@gnu.org> <87inhchab4.fsf@gnu.org> <87r2vzg0qb.fsf@gnu.org> From: Roel Janssen In-reply-to: <87r2vzg0qb.fsf@gnu.org> Date: Fri, 25 Aug 2017 18:19:36 +0200 Message-ID: <87a82ntyav.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27907@debbugs.gnu.org Ludovic Courtès writes: > Roel Janssen skribis: > >> Oops! I am sorry about this. Would it not break if we include a check for whether >> the node type is a package or not. Then, non-package node types are >> handled the “old way” and packages are handled the “new way”. >> >> I think we cannot have a generic way of exposing the specifics of a node >> type, so if we need to expose more information for the other node types, >> we have to add a type-specific implementation. > > Actually, we might need to discuss the specifics of why you wanted to do > it in the first place. :-) > > It is to pass extra rendering info to the backends? (It would be > helpful for instance to adjust the node color or size depending on > certain parameters such as its size or number of dependents.) Not necessarily rendering information, even though it could improve the displayment of packages like you say. I'd like to export more information to a graph database, so that the packages can be searched, explored and linked to in a graph that also contains stuff like how programs were run and what files that run produced. So, this is essentially an interoperability thing for communicating with other systems. > >> If this sounds like a good idea I'll write a new patch. And while I'm >> at it, what set of commands fully cover the graph code for all node >> types? Just all variants in 'guix graph --type=X'? > > “make check TESTS=tests/graph.scm” covers all the node types I think. > > Ludo’. Then I will run that command before I propose a new patch. Kind regards, Roel Janssen